Re: [PATCH 34/35] ARM: davinci: stop using defines from mach/irqs.h

David Lechner
2019-02-05T01:05:42Z

On 1/31/19 7:39 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> As the second step in preparation for mach/irqs.h removal - replace
> all constants defined there with the DAVINCI_INTC_IRQ() macro which
> takes the NR_IRQS offset into account.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---

Reviewed-by: David Lechner <david@lechnology.com>

> diff --git a/arch/arm/mach-davinci/devices.c b/arch/arm/mach-davinci/devices.c
> index e8dbbb7479ab..b8e5c5998872 100644
> --- a/arch/arm/mach-davinci/devices.c
> +++ b/arch/arm/mach-davinci/devices.c

...

> @@ -110,7 +110,7 @@ void __init davinci_init_ide(void)
> davinci_cfg_reg(DM644X_ATAEN);
> davinci_cfg_reg(DM644X_HDIREN);
> } else if (cpu_is_davinci_dm646x()) {
> - /* IRQ_DM646X_IDE is the same as IRQ_IDE */
> + /* DAVINCI_INTC_IRQ(22) is the same as DAVINCI_INTC_IRQ(22) */

This comment can be dropped.

> davinci_cfg_reg(DM646X_ATAEN);
> } else {
> WARN_ON(1);