From: Al Viro <viro@zeniv.linux.org.uk>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
syzbot <syzbot+16c3a70e1e9b29346c43@syzkaller.appspotmail.com>,
Eric Biggers <ebiggers@google.com>,
Souptick Joarder <jrdr.linux@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
David Rientjes <rientjes@google.com>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Subject: Re: general protection fault in relay_open_buf
Date: Fri, 1 Feb 2019 03:57:48 +0000 [thread overview]
Message-ID: <20190201035748.GL2217@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20190131105152.GB13686@kroah.com>
On Thu, Jan 31, 2019 at 11:51:52AM +0100, Greg KH wrote:
> Can you test the patch below?
>
> thanks,
>
> greg k-h
>
> @@ -461,7 +463,7 @@ static struct rchan_buf *relay_open_buf(struct rchan *chan, unsigned int cpu)
> dentry = chan->cb->create_buf_file(NULL, NULL,
> S_IRUSR, buf,
> &chan->is_global);
> - if (WARN_ON(dentry))
> + if (IS_ERR_OR_NULL(dentry))
> goto free_buf;
Huh? That makes no sense; is it IS_ERR on error or is it NULL
on error, or what? Besides, how did it work before?
next prev parent reply other threads:[~2019-02-01 3:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 18:53 general protection fault in relay_open_buf syzbot
2019-01-31 9:54 ` Kees Cook
2019-01-31 10:44 ` Greg KH
2019-01-31 10:51 ` Greg KH
2019-01-31 11:16 ` Dmitry Vyukov
2019-01-31 11:22 ` Greg KH
2019-01-31 11:28 ` Dmitry Vyukov
2019-01-31 11:53 ` syzbot
2019-01-31 11:35 ` syzbot
2019-01-31 11:29 ` Tetsuo Handa
2019-01-31 11:54 ` Greg KH
2019-01-31 18:31 ` Kees Cook
2019-01-31 18:46 ` Greg KH
2019-02-01 3:57 ` Al Viro [this message]
2019-02-01 9:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201035748.GL2217@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=ebiggers@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jrdr.linux@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=syzbot+16c3a70e1e9b29346c43@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox