From: Lee Jones <lee.jones@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] mfd: intel-lpss: Move linux/pm.h to the local header
Date: Fri, 1 Feb 2019 09:25:45 +0000 [thread overview]
Message-ID: <20190201092545.GH783@dell> (raw)
In-Reply-To: <20190124180328.76533-1-andriy.shevchenko@linux.intel.com>
On Thu, 24 Jan 2019, Andy Shevchenko wrote:
> We now using a common macro for PM operations in Intel LPSS driver,
> and, since that macro relies on the definition and macro from linux/pm.h
> header file, it's logical to include it directly in intel-lpss.h.
> Otherwise it's a bit fragile and requires a proper ordering
> of header inclusion in C files.
I don't agree with this. File which use various headers should
explicitly include them. Inheriting header files is non-optimal.
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mfd/intel-lpss-acpi.c | 1 -
> drivers/mfd/intel-lpss-pci.c | 1 -
> drivers/mfd/intel-lpss.h | 2 ++
> 3 files changed, 2 insertions(+), 2 deletions(-)
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-02-01 9:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 18:03 [PATCH v1] mfd: intel-lpss: Move linux/pm.h to the local header Andy Shevchenko
2019-01-29 14:48 ` Mika Westerberg
2019-02-01 9:25 ` Lee Jones [this message]
2019-02-01 10:05 ` Andy Shevchenko
2019-02-01 15:08 ` Lee Jones
2019-02-08 12:59 ` Andy Shevchenko
2019-02-12 8:49 ` Lee Jones
2019-02-12 8:49 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201092545.GH783@dell \
--to=lee.jones@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox