Re: [PATCH V4 01/13] perf/core, x86: Add PERF_SAMPLE_DATA_PAGE_SIZE

Peter Zijlstra
2019-02-04T10:54:32Z

On Fri, Feb 01, 2019 at 11:16:51AM -0500, Liang, Kan wrote:

> > if (p4d_large(*p4d)) {
>
> This one looks like x86 specific?

> > if (pud_large(*pud)) {

> > if (pmd_large(*pmd)) {

Kirill did indeed note that p*_large() isn't universally availale (but
there's definitely !x86 archs that have them). He also said it would
probably make sense to have them universally available and might help
clean up mm/gup.c a little.

A quick grep shows that: ARM, PowerPC, S390, Sparc and x86 have
'pmd_large'.

Anyway; it probably makes sense (and shouldn't be too hard) to fix up
all architectures to provide this.