From: Darren Hart <dvhart@infradead.org>
To: Stuart Hayes <stuart.w.hayes@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
andy@infradead.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dell_rbu: stop abusing the DMA API
Date: Fri, 1 Feb 2019 15:17:02 -0800 [thread overview]
Message-ID: <20190201231702.GD105752@fedora.eng.vmware.com> (raw)
In-Reply-To: <4fce2a6c-2e57-bc29-0dca-8ed3bef95333@gmail.com>
On Fri, Feb 01, 2019 at 12:28:46PM -0600, Stuart Hayes wrote:
>
> On 1/29/2019 1:34 AM, Christoph Hellwig wrote:
> > For some odd reason dell_rbu actually seems to want the physical and
> > not a bus address for the allocated buffer. Lets assume that actually
> > is correct given that it is BIOS-related and that is a good source
> > of insanity. In that case we should not use dma_alloc_coherent with
> > a NULL device to allocate memory, but use GFP_DMA32 to stay under
> > the 32-bit BIOS limit.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
...
>
> Acked-by: Stuart Hayes <stuart.w.hayes@gmail.com>
>
Ah, prematurely pulled in Mario - thanks Stuart.
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2019-02-01 23:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 7:34 [PATCH] dell_rbu: stop abusing the DMA API Christoph Hellwig
2019-02-01 18:28 ` Stuart Hayes
2019-02-01 23:17 ` Darren Hart [this message]
2019-02-01 23:15 ` Darren Hart
2019-02-02 17:16 ` Christoph Hellwig
2019-02-07 20:47 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201231702.GD105752@fedora.eng.vmware.com \
--to=dvhart@infradead.org \
--cc=andy@infradead.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).