From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E32EC282D7 for ; Sat, 2 Feb 2019 07:13:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 24B6D20815 for ; Sat, 2 Feb 2019 07:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549091634; bh=d5lF9CVaOgTQMmq5P4+NuVQmBMfctFDudkgRa1bohRU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=a+3hr8DOapFhDi2FjyDkvHjAJiOoebKfm+1CNiVQTWYuDqzpuYvU2YbXNp89f0kmh JoyhfGVTxD/jgMftDKNrt9OwYruAV5+hN3TeE8XpI39FbDfPkvzmsgnKZXLm4FTyD9 sbfR4EHVfJsRyo92lgI3vusmZykbL1Dhv3JEAr4M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727750AbfBBHNw (ORCPT ); Sat, 2 Feb 2019 02:13:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:34126 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726659AbfBBHNw (ORCPT ); Sat, 2 Feb 2019 02:13:52 -0500 Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C22D720863; Sat, 2 Feb 2019 07:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549091631; bh=d5lF9CVaOgTQMmq5P4+NuVQmBMfctFDudkgRa1bohRU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MuzRsxeEyBOGiRnh+++cbohi26d/RarfvYnYCqk4gFP89Kqf6AKOkJmFzmblDTV+r ANlFAO3m4Px0pf83OdIc9GQcza/mIM3Z1/pPS5urxSq6OhZS5hH1wy3R017qe5JpPb DeYLn5ueptsdb8d0bygXYWUY2vNcgO74Ro6FJZ/Y= Date: Sat, 2 Feb 2019 08:13:38 +0100 From: Boris Brezillon To: Cc: , , , , , , , , , , , , Subject: Re: [PATCH v3 08/13] spi: atmel-quadspi: drop unused and NOP transfer macros Message-ID: <20190202081338.01056dce@bbrezillon> In-Reply-To: <20190202040653.1217-9-tudor.ambarus@microchip.com> References: <20190202040653.1217-1-tudor.ambarus@microchip.com> <20190202040653.1217-9-tudor.ambarus@microchip.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2 Feb 2019 04:07:33 +0000 wrote: > From: Tudor Ambarus > > Remove NOP when setting read transfer type. Remove useless > setting of write transfer type when > op->data.dir == SPI_MEM_DATA_IN && !op->data.nbytes. > > QSPI_IFR_TFRTYP_TRSFR_WRITE is specific just to sama5d2 qspi, > rename it to QSPI_IFR_SAMA5D2_WRITE_TRSFR. > > Signed-off-by: Tudor Ambarus > --- > v3: new patch > > drivers/spi/atmel-quadspi.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c > index d26d4cd0e36b..bfa5f5e92d96 100644 > --- a/drivers/spi/atmel-quadspi.c > +++ b/drivers/spi/atmel-quadspi.c > @@ -113,11 +113,7 @@ > #define QSPI_IFR_OPTL_4BIT (2 << 8) > #define QSPI_IFR_OPTL_8BIT (3 << 8) > #define QSPI_IFR_ADDRL BIT(10) > -#define QSPI_IFR_TFRTYP_MASK GENMASK(13, 12) > -#define QSPI_IFR_TFRTYP_TRSFR_READ (0 << 12) > -#define QSPI_IFR_TFRTYP_TRSFR_READ_MEM (1 << 12) > -#define QSPI_IFR_TFRTYP_TRSFR_WRITE (2 << 12) > -#define QSPI_IFR_TFRTYP_TRSFR_WRITE_MEM (3 << 13) > +#define QSPI_IFR_SAMA5D2_WRITE_TRSFR BIT(13) Can you define QSPI_IFR_TFRTYP_MEM (bit 12) even if it's not used yet? > #define QSPI_IFR_CRM BIT(14) > #define QSPI_IFR_NBDUM_MASK GENMASK(20, 16) > #define QSPI_IFR_NBDUM(n) (((n) << 16) & QSPI_IFR_NBDUM_MASK) > @@ -273,10 +269,8 @@ static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op) > if (op->data.nbytes) > ifr |= QSPI_IFR_DATAEN; > > - if (op->data.dir == SPI_MEM_DATA_IN && op->data.nbytes) > - ifr |= QSPI_IFR_TFRTYP_TRSFR_READ; > - else > - ifr |= QSPI_IFR_TFRTYP_TRSFR_WRITE; > + if (op->data.dir == SPI_MEM_DATA_OUT) > + ifr |= QSPI_IFR_SAMA5D2_WRITE_TRSFR; > > /* Clear pending interrupts */ > (void)readl_relaxed(base + QSPI_SR);