From: Alexey Dobriyan <adobriyan@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Zhang Yanmin <yanmin.zhang@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] linux/kernel.h: use 'short' to define USHRT_MAX, SHRT_MAX, SHRT_MIN
Date: Sat, 2 Feb 2019 19:31:05 +0300 [thread overview]
Message-ID: <20190202163105.GA28518@avx2> (raw)
In-Reply-To: <1549123585-13800-1-git-send-email-yamada.masahiro@socionext.com>
On Sun, Feb 03, 2019 at 01:06:24AM +0900, Masahiro Yamada wrote:
> The log of commit 44f564a4bf6a ("ipc: add definitions of USHORT_MAX
> and others") did not explain why it used (s16) and (u16) instead of
> (short) and (unsigned short).
>
> Let's use (short) and (unsigned short), which is more sensible, and
> more consistent with the other MAX/MIN defines.
>
> As you see in include/uapi/asm-generic/int-ll64.h, s16/u16 are
> typedef'ed as signed/unsigned short. So, this commit does not have
> a functional change.
> -#define USHRT_MAX ((u16)(~0U))
> -#define SHRT_MAX ((s16)(USHRT_MAX>>1))
> -#define SHRT_MIN ((s16)(-SHRT_MAX - 1))
> +#define USHRT_MAX ((unsigned short)(~0U))
^ ^
+---+
unnecessary ()
> +#define SHRT_MAX ((short)(USHRT_MAX>>1))
> +#define SHRT_MIN ((short)(-SHRT_MAX - 1))
"short" and "unsigned short" are probably the most useless C types.
I doubt their usage should be promoted.
next prev parent reply other threads:[~2019-02-02 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-02 16:06 [PATCH 1/2] linux/kernel.h: use 'short' to define USHRT_MAX, SHRT_MAX, SHRT_MIN Masahiro Yamada
2019-02-02 16:06 ` [PATCH 2/2] linux/kernel.h: split *_MAX and *_MIN macros into <linux/limits.h> Masahiro Yamada
2019-02-02 16:31 ` Alexey Dobriyan [this message]
2019-02-02 16:36 ` [PATCH 1/2] linux/kernel.h: use 'short' to define USHRT_MAX, SHRT_MAX, SHRT_MIN Alexey Dobriyan
2019-02-03 1:09 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190202163105.GA28518@avx2 \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox