From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F8F2C169C4 for ; Sun, 3 Feb 2019 14:24:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D93E2084A for ; Sun, 3 Feb 2019 14:24:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549203867; bh=PrXer47KHA40S2YqkSEELxve4hCip8gF445pVwtHm/A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=MmuLkQoyy5YYfevr5SmN+CZjyBmRPwVQ3efIyftLnZ7jI+8XgWtfJs1KO0Lf1pyAE IidK7OFkqLHrsQVwAYxg58cHJv5B3pSWIPmvYruLCVZjtOjABAzoGgR+Ptlp57u8cV ITINYg9XWoMVNx1tI/SGqoGfWx0oBN9T3sWMamfg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728177AbfBCOYZ (ORCPT ); Sun, 3 Feb 2019 09:24:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:50606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730853AbfBCOYV (ORCPT ); Sun, 3 Feb 2019 09:24:21 -0500 Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 93F102084A; Sun, 3 Feb 2019 14:24:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549203860; bh=PrXer47KHA40S2YqkSEELxve4hCip8gF445pVwtHm/A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hcoRJHeBfU6/8YFjJ+eMaI36hMnLgWme4GDaDwPLJYkv7Z2//AjQyqgy+16cuzsa7 xZAozvNWZT4Q7s0acQL6qHjJbO68085xsYrXXyomhXx1/ju+gTQxKC6xVesbCkDP/5 WggQQaxTLhHgWd8XA6qeBt7L/nnm9qyqxZFBG5So= Date: Sun, 3 Feb 2019 15:24:08 +0100 From: Boris Brezillon To: Paul Cercueil Cc: David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Rob Herring , Mark Rutland , Miquel Raynal , Harvey Hunt , Mathieu Malaterre , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/9] mtd: rawnand: jz4780: Add support for the JZ4740 Message-ID: <20190203152408.2795de7e@bbrezillon> In-Reply-To: <1549203050.1950.3@crapouillou.net> References: <20190202231926.2444-1-paul@crapouillou.net> <20190202231926.2444-5-paul@crapouillou.net> <20190203083151.4fc29c5b@bbrezillon> <1549202213.1950.1@crapouillou.net> <20190203150827.401ac31d@bbrezillon> <1549203050.1950.3@crapouillou.net> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 03 Feb 2019 11:10:50 -0300 Paul Cercueil wrote: > Le dim. 3 f=C3=A9vr. 2019 =C3=A0 11:08, Boris Brezillon =20 > a =C3=A9crit : > > On Sun, 03 Feb 2019 10:56:53 -0300 > > Paul Cercueil wrote: > > =20 > >> Le dim. 3 f=C3=A9vr. 2019 =C3=A0 4:31, Boris Brezillon=20 > >> > >> a =C3=A9crit : =20 > >> > On Sat, 2 Feb 2019 20:19:21 -0300 > >> > Paul Cercueil wrote: > >> > =20 > >> >> Add support for probing the jz4780-nand driver on the JZ4740 SoC > >> >> from > >> >> Ingenic. > >> >> > >> >> Signed-off-by: Paul Cercueil > >> >> --- > >> >> > >> >> Changes: > >> >> > >> >> v2: - Add support for the JZ4740 and not the JZ4725B: they =20 > >> behave =20 > >> >> the > >> >> same, and JZ4740 is fully upstream while JZ4725B is not. = =20 > >> The =20 > >> >> JZ4725B devicetree will then simply use the > >> >> "ingenic,jz4740-nand" > >> >> compatible string. > >> >> - Fix the number of bytes for the ECC when the ECC strength = =20 > >> is =20 > >> >> 4. > >> >> This is needed for the JZ4740, which uses Reed-Solomon > >> >> instead of > >> >> BCH. > >> >> > >> >> drivers/mtd/nand/raw/ingenic/jz4780_nand.c | 48 > >> >> +++++++++++++++++----- =20 > >> > > >> > If we're going to make the driver compatible with jz4740 and =20 > >> jz4725b =20 > >> > maybe we should rename the source files jz47xx_{nand,bch}.{c,h}. =20 > >>=20 > >> I don't know about that. Adding support for new hardware isn't a=20 > >> good > >> reason to > >> rename the driver, or so I've been told around here, as you then=20 > >> make > >> it harder > >> to review the git history of the driver. =20 > >=20 > > You already move files to a sub-directory so that doesn't make a huge > > difference, history will be hard to follow because of this move=20 > > anyway. =20 >=20 > Yes, but if I merge the *_bch.c files together, and eventually drop > jz4740-nand.c, does it still make sense to move to a sub-directory? >=20 Still prefer to make things explicit over preserving file names to make git log history linear. And anyway, how hard is it to figure out that the last commit in git log drivers/mtd/nand/raw/.c is moving the file (there might even be an option for that)?