From: Peter Zijlstra <peterz@infradead.org>
To: "Liang, Kan" <kan.liang@linux.intel.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
acme@kernel.org, tglx@linutronix.de, mingo@redhat.com,
linux-kernel@vger.kernel.org, eranian@google.com,
jolsa@redhat.com, namhyung@kernel.org, ak@linux.intel.com,
luto@amacapital.net, Vlastimil Babka <vbabka@suse.cz>,
Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH V4 01/13] perf/core, x86: Add PERF_SAMPLE_DATA_PAGE_SIZE
Date: Mon, 4 Feb 2019 11:54:09 +0100 [thread overview]
Message-ID: <20190204105409.GA17550@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <9fbb7bd3-b150-1ed1-bf03-c44d789172d0@linux.intel.com>
On Fri, Feb 01, 2019 at 11:16:51AM -0500, Liang, Kan wrote:
> > if (p4d_large(*p4d)) {
>
> This one looks like x86 specific?
> > if (pud_large(*pud)) {
> > if (pmd_large(*pmd)) {
Kirill did indeed note that p*_large() isn't universally availale (but
there's definitely !x86 archs that have them). He also said it would
probably make sense to have them universally available and might help
clean up mm/gup.c a little.
A quick grep shows that: ARM, PowerPC, S390, Sparc and x86 have
'pmd_large'.
Anyway; it probably makes sense (and shouldn't be too hard) to fix up
all architectures to provide this.
next prev parent reply other threads:[~2019-02-04 10:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 20:27 [PATCH V4 01/13] perf/core, x86: Add PERF_SAMPLE_DATA_PAGE_SIZE kan.liang
2019-01-31 20:27 ` [PATCH V4 02/13] perf tools: Support new sample type for data page size kan.liang
2019-01-31 20:27 ` [PATCH V4 03/13] perf script: Support " kan.liang
2019-01-31 20:27 ` [PATCH V4 04/13] perf sort: Add sort option for " kan.liang
2019-01-31 20:27 ` [PATCH V4 05/13] perf mem: Factor out a function to generate sort order kan.liang
2019-01-31 20:27 ` [PATCH V4 06/13] perf mem: Clean up output format kan.liang
2019-01-31 20:28 ` [PATCH V4 07/13] perf mem: Support data page size kan.liang
2019-01-31 20:28 ` [PATCH V4 08/13] perf test: Add test case for PERF_SAMPLE_DATA_PAGE_SIZE kan.liang
2019-01-31 20:28 ` [PATCH V4 09/13] perf/core, x86: Add support for PERF_SAMPLE_CODE_PAGE_SIZE kan.liang
2019-01-31 20:28 ` [PATCH V4 10/13] perf tools: " kan.liang
2019-01-31 20:28 ` [PATCH V4 11/13] perf script: " kan.liang
2019-01-31 20:28 ` [PATCH V4 12/13] perf report: " kan.liang
2019-01-31 20:28 ` [PATCH V4 13/13] perf test: Add test case " kan.liang
2019-02-01 9:22 ` [PATCH V4 01/13] perf/core, x86: Add PERF_SAMPLE_DATA_PAGE_SIZE Peter Zijlstra
2019-02-01 10:03 ` Peter Zijlstra
2019-02-01 10:36 ` Kirill A. Shutemov
2019-02-01 12:43 ` Peter Zijlstra
2019-02-01 12:47 ` Peter Zijlstra
2019-02-01 16:16 ` Liang, Kan
2019-02-04 10:54 ` Peter Zijlstra [this message]
2019-02-06 20:23 ` Liang, Kan
2019-02-01 10:34 ` Kirill A. Shutemov
2019-02-01 14:45 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204105409.GA17550@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox