From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ADADC282C4 for ; Mon, 4 Feb 2019 16:33:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2598A2083B for ; Mon, 4 Feb 2019 16:33:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731676AbfBDQdS (ORCPT ); Mon, 4 Feb 2019 11:33:18 -0500 Received: from muru.com ([72.249.23.125]:37462 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727058AbfBDQdR (ORCPT ); Mon, 4 Feb 2019 11:33:17 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 06B19808C; Mon, 4 Feb 2019 16:33:23 +0000 (UTC) Date: Mon, 4 Feb 2019 08:33:12 -0800 From: Tony Lindgren To: Roger Quadros Cc: ohad@wizery.com, bjorn.andersson@linaro.org, s-anna@ti.com, david@lechnology.com, nsekhar@ti.com, t-kristo@ti.com, nsaulnier@ti.com, jreeder@ti.com, m-karicheri2@ti.com, woods.technical@gmail.com, linux-omap@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 01/14] dt-bindings: remoteproc: Add TI PRUSS bindings Message-ID: <20190204163312.GI5720@atomide.com> References: <1549290167-876-1-git-send-email-rogerq@ti.com> <1549290167-876-2-git-send-email-rogerq@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1549290167-876-2-git-send-email-rogerq@ti.com> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, * Roger Quadros [190204 14:23]: > From: Suman Anna ... > +Example: > +======== > +1. /* AM33xx PRU-ICSS */ > + > + pruss: pruss@0 { > + compatible = "ti,am3356-pruss"; > + reg = <0x0 0x2000>, > + <0x2000 0x2000>, > + <0x10000 0x3000>; > + reg-names = "dram0", "dram1", > + "shrdram2"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; Thanks for fixing up the reg ranges for the top level node. Ideally there would not even be a top level node here as AFAIK the whole PRUSS is a collection of devices on a PRU internal interconnect. So following that path a bit further.. How about just get rid of the top level node and just do: pruss: pruss@0 { dram0: memory@0 { device_type = "memory"; reg = <0x0 0x2000>; }; dram1: memory@2000 { device_type = "memory"; reg = <0x2000 0x2000>; }; shrdram2: memory@10000 { device_type = "memory"; reg = <0x10000 0x3000>; }; pruss_cfg: cfg@26000 { ... }; ... }; If the device_type = "memory" cannot be used here for being specific to the top level properties, then there's probably some other generic property usable here :) > + pruss_mii_rt: mii_rt@32000 { > + reg = <0x32000 0x58>; > + }; The node name should not have underscores so pruss_mii_rt: mii-rt@32000. Please check the others too, like app_node. > + app_node: app_node { > + prus = <&pru0>, <&pru1>; > + firmware-name = "pruss-app-fw", "pruss-app-fw-2"; > + ti,pruss-gp-mux-sel = <2>, <1>; > + /* setup interrupts for prus: > + prus[0] => pru1_0: ev=16, chnl=2, host-irq=7, > + prus[1] => pru1_1: ev=19, chnl=1, host-irq=3 */ > + ti,pru-interrupt-map = <0 16 2 7 >, <1 19 1 3>; > + } If the ti,pruss-gp-mux-sel and ti,pru-interrupt-map are firmware configuration options, maybe leave them out of the dts completely and make the app-node optional. And have a proper compatible for this node such as "ti,pruss-app-xyz". And this should be only set if the the hardware is wired up in such way that things need to be configured in the dts rather than by the firmware. And then you can just hide mux-sel and interrupt-map behind the compatible property for that hardware. And leave them out from the dts and have the handling driver would set mux-sel and interrupt-map based on the match->data during probe. Regards, Tony