From: Dave Chinner <david@fromorbit.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: allow disabling xfs tracepoints via Kconfig
Date: Tue, 5 Feb 2019 08:53:32 +1100 [thread overview]
Message-ID: <20190204215332.GB14116@dastard> (raw)
In-Reply-To: <20190204212035.9919-1-linux@rasmusvillemoes.dk>
On Mon, Feb 04, 2019 at 10:20:35PM +0100, Rasmus Villemoes wrote:
> linux/tracepoints.h allows individual subsystems to disable their
> tracepoints. Add such a knob for xfs. Disabling XFS_TRACEPOINTS
> reduces the resident size of xfs.ko by about a third, or ~350 KiB.
Ok, now we can't debug typical problems on live production systems
if tracepoints are turned off on the user/distro kernels. So under
what circumstances would we ever want to turn off tracepoints on
XFS?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2019-02-04 21:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 21:20 [PATCH] xfs: allow disabling xfs tracepoints via Kconfig Rasmus Villemoes
2019-02-04 21:37 ` Darrick J. Wong
2019-02-04 21:53 ` Dave Chinner [this message]
2019-02-04 22:12 ` Rasmus Villemoes
2019-02-04 23:13 ` Dave Chinner
2019-02-05 10:00 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204215332.GB14116@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox