public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Tony Jones <tonyj@suse.de>,
	Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
	Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: perf: python3 + tests attr.py failing
Date: Tue, 5 Feb 2019 10:28:46 -0300	[thread overview]
Message-ID: <20190205132846.GO5593@kernel.org> (raw)
In-Reply-To: <20190205130843.GN5593@kernel.org>

Em Tue, Feb 05, 2019 at 10:08:43AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Feb 05, 2019 at 10:02:14AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Mon, Feb 04, 2019 at 09:37:38PM +0100, Jiri Olsa escreveu:
> > > On Mon, Feb 04, 2019 at 12:10:42PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > Noticed this now when building with PYTHON=python3, can you take a look?
> > > > For now I'm reinstalling python2-devel and building with it, i.e.
> > > > removing that PYTHON=python3 make command line variable.
> > > which Fedora are you on 29? I'm on 28
>  
> > [acme@quaco ~]$ cat /etc/fedora-release 
> > Fedora release 29 (Twenty Nine)
>  
> > [acme@quaco tumbleweed]$ rpm -qa | grep python3 | wc -l
> > 96
> > [acme@quaco tumbleweed]$ rpm -q python3-devel
> > python3-devel-3.7.2-4.fc29.x86_64
> > [acme@quaco tumbleweed]$ 
> > 
> > But it is a SyntaxError, so something simpler, looking up...
> 
> So python 3 needs to have that as:
> 
> 	except Unsup as obj:
> 
> How to make this work with both is what I'm trying to figure out now...

So, all this is fixed in perf/core already by:

commit 35ea7e4bbb89ecd32057f5f6a2a8feb0d7224e51
Author: Tony Jones <tonyj@suse.de>
Date:   Wed Jan 23 16:52:29 2019 -0800

    perf script python: Add Python3 support to tests/attr.py
    
    Support both Python 2 and Python 3 in tests/attr.py
    
    The use of "except as" syntax implies the minimum supported Python2 version is
    now v2.6

 ------------------

 So nevermind, sorry for the noise :-)

- Arnaldo

  reply	other threads:[~2019-02-05 13:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-04 15:10 perf: python3 + tests attr.py failing Arnaldo Carvalho de Melo
2019-02-04 20:37 ` Jiri Olsa
2019-02-05 13:02   ` Arnaldo Carvalho de Melo
2019-02-05 13:08     ` Arnaldo Carvalho de Melo
2019-02-05 13:28       ` Arnaldo Carvalho de Melo [this message]
2019-02-05 13:49   ` Arnaldo Carvalho de Melo
2019-02-05 15:43     ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190205132846.GO5593@kernel.org \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=ravi.bangoria@linux.ibm.com \
    --cc=s1seetee@linux.vnet.ibm.com \
    --cc=tonyj@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox