* Re: [PATCH] mtd: rawnand: jz4780: fix object reference leaks in jz4780_bch_get
[not found] <HK0PR02MB36349BDCE693F67F150B0172B26E0@HK0PR02MB3634.apcprd02.prod.outlook.com>
@ 2019-02-05 13:30 ` Miquel Raynal
0 siblings, 0 replies; only message in thread
From: Miquel Raynal @ 2019-02-05 13:30 UTC (permalink / raw)
To: wen yang
Cc: harveyhuntnexus@gmail.com, bbrezillon@kernel.org, richard@nod.at,
dwmw2@infradead.org, computersforpeace@gmail.com,
marek.vasut@gmail.com, nicolas.ferre@microchip.com,
alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Hi wen,
wen yang <yellowriver2010@hotmail.com> wrote on Tue, 5 Feb 2019
09:36:48 +0000:
> of_find_device_by_node() takes a reference to the struct device
> when it finds a match via get_device, there is no need to call
> get_device() twice.
> We also should make sure to drop the reference to the device
> taken by of_find_device_by_node() on driver unbind.
>
> Fixes: ae02ab00aa3c ("mtd: nand: jz4780: driver for NAND devices on JZ4780 SoCs")
> Signed-off-by: Wen Yang <yellowriver2010@hotmail.com>
> Suggested-by: Boris Brezillon <bbrezillon@kernel.org>
> Cc: Harvey Hunt <harveyhuntnexus@gmail.com>
> Cc: Boris Brezillon <bbrezillon@kernel.org>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: linux-mtd@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/mtd/nand/raw/jz4780_bch.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/jz4780_bch.c b/drivers/mtd/nand/raw/jz4780_bch.c
> index 7201827..d0ce5de 100644
> --- a/drivers/mtd/nand/raw/jz4780_bch.c
> +++ b/drivers/mtd/nand/raw/jz4780_bch.c
> @@ -279,17 +279,24 @@ static struct jz4780_bch *jz4780_bch_get(struct device_node *np)
> {
> struct platform_device *pdev;
> struct jz4780_bch *bch;
> + int ret;
>
> pdev = of_find_device_by_node(np);
> - if (!pdev || !platform_get_drvdata(pdev))
> + if (!pdev)
> return ERR_PTR(-EPROBE_DEFER);
> -
> - get_device(&pdev->dev);
> + if (!platform_get_drvdata(pdev)) {
> + ret = -EPROBE_DEFER;
> + goto err_put_device;
> + }
>
> bch = platform_get_drvdata(pdev);
> clk_prepare_enable(bch->clk);
>
> return bch;
> +
> +err_put_device:
> + put_device(&pdev->dev);
> + return ERR_PTR(ret);
While there is only one user of this label, I think we don't want it.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] only message in thread