From: Borislav Petkov <bp@alien8.de>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Fenghua Yu <fenghua.yu@intel.com>, Ingo Molnar <mingo@redhat.com>,
H Peter Anvin <hpa@zytor.com>, Ashok Raj <ashok.raj@intel.com>,
Michael Chan <michael.chan@broadcom.com>,
Ravi V Shankar <ravi.v.shankar@intel.com>,
Ricardo Neri <ricardo.neri@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH v3 08/10] x86/setcpuid: Add kernel option setcpuid
Date: Tue, 5 Feb 2019 16:43:09 +0100 [thread overview]
Message-ID: <20190205154309.GU21801@zn.tnic> (raw)
In-Reply-To: <ec193a66-b395-ed1a-e39c-40fa1ece3f56@intel.com>
On Tue, Feb 05, 2019 at 07:19:16AM -0800, Dave Hansen wrote:
> This is one of the few times that we're pretty confident that folks will
> use this. The reason we're going to this trouble is that the split lock
> detection is wanted by actual customers, and they want it before it's
> implemented on a processor with real enumeration.
>
> This isn't something we want everybody and their grandma to turn on;
> it's a rather specialized feature. It's really only for folks that care
> about the latency incurred across the entire system on split lock
> operations.
...
> It's not for developers. This really is for (somewhat niche) end users
> that want split lock detection in production. This is all really an
> effort to get them running mainline or real distro kernels.
This all sounds to me like it shouldn't even be mainline but in a
special, evaluation kernel. If anything, it should be default off and be
opted-in by a cmdline switch. None of that *cpuid=* toggling dance.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-02-05 15:43 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-02 5:14 [PATCH v3 00/10] x86/split_lock: Enable #AC exception for split locked accesses Fenghua Yu
2019-02-02 5:14 ` [PATCH v3 01/10] x86/common: Align cpu_caps_cleared and cpu_caps_set to unsigned long Fenghua Yu
2019-02-02 5:14 ` [PATCH v3 02/10] drivers/net/b44: Align pwol_mask to unsigned long for better performance Fenghua Yu
2019-02-02 5:14 ` [PATCH v3 03/10] wlcore: Align reg_ch_conf_pending and tmp_ch_bitmap " Fenghua Yu
2019-02-02 5:14 ` [PATCH v3 04/10] x86/split_lock: Align x86_capability to unsigned long to avoid split locked access Fenghua Yu
2019-02-02 5:14 ` [PATCH v3 05/10] x86/clearcpuid: Support multiple clearcpuid options Fenghua Yu
2019-02-02 5:14 ` [PATCH v3 06/10] x86/clearcpuid: Support feature flag string in kernel option clearcpuid Fenghua Yu
2019-02-02 5:14 ` [PATCH v3 07/10] Change document for " Fenghua Yu
2019-02-02 5:14 ` [PATCH v3 08/10] x86/setcpuid: Add kernel option setcpuid Fenghua Yu
2019-02-04 17:49 ` Thomas Gleixner
2019-02-04 19:05 ` Dave Hansen
2019-02-04 19:57 ` Borislav Petkov
2019-02-04 20:46 ` Dave Hansen
2019-02-04 21:40 ` Borislav Petkov
2019-02-04 22:14 ` Fenghua Yu
2019-02-05 6:10 ` Borislav Petkov
2019-02-04 23:24 ` Dave Hansen
2019-02-05 6:18 ` Borislav Petkov
2019-02-05 16:46 ` Dave Hansen
2019-02-05 17:09 ` Peter Zijlstra
2019-02-05 8:57 ` Peter Zijlstra
2019-02-05 13:15 ` Peter Zijlstra
2019-02-05 8:48 ` Peter Zijlstra
2019-02-05 15:19 ` Dave Hansen
2019-02-05 15:43 ` Borislav Petkov [this message]
2019-02-05 18:26 ` Fenghua Yu
2019-02-05 17:04 ` Peter Zijlstra
2019-02-10 19:20 ` Thomas Gleixner
2019-02-11 19:16 ` Fenghua Yu
2019-02-12 13:37 ` Peter Zijlstra
2019-02-12 13:51 ` Thomas Gleixner
2019-02-12 16:48 ` Peter Zijlstra
2019-02-12 16:50 ` Dave Hansen
2019-02-12 17:52 ` Yu, Fenghua
2019-02-04 21:09 ` Fenghua Yu
2019-02-05 8:51 ` Peter Zijlstra
2019-02-05 15:21 ` Dave Hansen
2019-02-05 15:34 ` Peter Zijlstra
2019-02-02 5:14 ` [PATCH v3 09/10] x86/split_lock: Define #AC for split lock feature Fenghua Yu
2019-02-04 18:41 ` Dave Hansen
2019-02-04 18:45 ` Fenghua Yu
2019-02-04 19:00 ` Dave Hansen
2019-02-04 19:03 ` Fenghua Yu
2019-02-02 5:14 ` [PATCH v3 10/10] x86/split_lock: Handle #AC exception for split lock Fenghua Yu
2019-02-04 11:00 ` kbuild test robot
2019-02-04 14:43 ` kbuild test robot
2019-02-11 10:53 ` Ingo Molnar
2019-02-11 18:10 ` Fenghua Yu
2019-02-13 8:14 ` Ingo Molnar
2019-02-13 14:37 ` Yu, Fenghua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205154309.GU21801@zn.tnic \
--to=bp@alien8.de \
--cc=ashok.raj@intel.com \
--cc=dave.hansen@intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=ravi.v.shankar@intel.com \
--cc=ricardo.neri@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).