Re: [PATCH 1/6] vmw_balloon: bump version number

Greg Kroah-Hartman
2019-02-06T21:06:21Z

On Wed, Feb 06, 2019 at 08:39:52PM +0000, Nadav Amit wrote:
> > On Feb 6, 2019, at 8:42 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Feb 05, 2019 at 09:13:31PM -0800, Nadav Amit wrote:
> >> Following recent changes.
> >>
> >> Signed-off-by: Nadav Amit <namit@vmware.com>
> >> ---
> >> drivers/misc/vmw_balloon.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
> >> index f8240b87df22..7294f305753f 100644
> >> --- a/drivers/misc/vmw_balloon.c
> >> +++ b/drivers/misc/vmw_balloon.c
> >> @@ -34,7 +34,7 @@
> >>
> >> MODULE_AUTHOR("VMware, Inc.");
> >> MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver");
> >> -MODULE_VERSION("1.5.0.0-k");
> >> +MODULE_VERSION("1.6.0.0-k");
> >
> > Please just drop this pointless line, it means nothing and is always out
> > of date. It's been removed from many other drivers, and I really don't
> > want to see it come back.
> >
> > Your driver "version" is the kernel version, full stop. That's all you
> > need to ever worry about.
>
> I understand, and I will inform those who asked for the version bump.
>
> Having said that, I do not see a reference for this policy. I understand
> that you removed the MODULE_VERSION from in-kernel drivers, but I also see
> that you accepted several drivers last year that used MODULE_VERSION.

I messed up, and will be glad to take patches to remove them. Usually
that's the last thing I remember to check when reviewing patches, I
can always use the help :)

Also, I only received 1 patch in this series, did something go wrong
with the sending of it?

thanks,

greg k-h