From: Christoph Hellwig <hch@lst.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma-direct: Export dma_direct_alloc() and dma_direct_free()
Date: Wed, 6 Feb 2019 07:57:50 +0100 [thread overview]
Message-ID: <20190206065749.GA23392@lst.de> (raw)
In-Reply-To: <20190205222912.GC1372@mithrandir>
On Tue, Feb 05, 2019 at 11:29:12PM +0100, Thierry Reding wrote:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/gpu/host1x/cdma.c#n106
> >
> > Yes, I think we I can come up with a nicer helper for that.
>
> One thing I could also try is to remove direct IOMMU API usage at least
> from the host1x driver. I think this might work nowadays.
>
> For Tegra DRM we still need direct IOMMU API usage because we need to be
> able to map into an IOMMU domain without knowing the struct device *
> that we're mapping for (it could be needed by any of up to four display
> controllers). For host1x we always only have one struct device *, so the
> DMA mapping API should be good enough.
If you can convert it to plain DMA API usage, please do.
I did look into an IOMMU API memory allocator, and while we can do it
easily for coherent devices, we need some arch hooks for non-coherent
device support. With a pending series from me we have those for arm64,
but 32-bit arm support will require a lot more work first.
next prev parent reply other threads:[~2019-02-06 6:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 11:06 [PATCH] dma-direct: Export dma_direct_alloc() and dma_direct_free() Thierry Reding
2019-02-05 16:10 ` Christoph Hellwig
2019-02-05 16:20 ` Thierry Reding
2019-02-05 16:38 ` Christoph Hellwig
2019-02-05 17:56 ` Thierry Reding
2019-02-05 18:02 ` Christoph Hellwig
2019-02-05 22:29 ` Thierry Reding
2019-02-06 6:57 ` Christoph Hellwig [this message]
2019-02-06 7:37 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206065749.GA23392@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox