From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FF57C169C4 for ; Wed, 6 Feb 2019 08:57:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC80420823 for ; Wed, 6 Feb 2019 08:57:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728708AbfBFI5v convert rfc822-to-8bit (ORCPT ); Wed, 6 Feb 2019 03:57:51 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:37731 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728278AbfBFI5u (ORCPT ); Wed, 6 Feb 2019 03:57:50 -0500 X-Originating-IP: 90.88.22.177 Received: from xps13 (aaubervilliers-681-1-80-177.w90-88.abo.wanadoo.fr [90.88.22.177]) (Authenticated sender: miquel.raynal@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id C18C1E0009; Wed, 6 Feb 2019 08:57:44 +0000 (UTC) Date: Wed, 6 Feb 2019 09:57:43 +0100 From: Miquel Raynal To: Gregory Clement , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Kishon Vijay Abraham I Cc: , , linux-kernel@vger.kernel.org, Rob Herring , Mark Rutland , Thomas Petazzoni , Antoine Tenart , Maxime Chevallier , Nadav Haklai , Marcin Wojtas , Grzegorz Jaszczyk Subject: Re: [PATCH v5 0/7] Add Armada 3700 COMPHY support Message-ID: <20190206095743.5eed3584@xps13> In-Reply-To: <20190108163124.6409-1-miquel.raynal@bootlin.com> References: <20190108163124.6409-1-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kishon, Miquel Raynal wrote on Tue, 8 Jan 2019 17:31:17 +0100: > Hello, > > This series adds a new driver to support Armada 3700 COMPHY IP. > The series has been tested on an ESPRESSObin with SATA, PCIe > and USB3 host. For this purpose, patch 1 enumerates the SATA PHY > mode. The SGMII PHY mode that is supported by the IP has been written > (uses SMC calls anyway) but could not be tested on this platform. > > Three series will follow to add PHY support (or at least a PHY nodes > in the A3700/ESPRESSObin device trees) to the MVEBU AHCI driver, the > Aardvark PCI controller driver and the MVEBU xHCI driver. All this is > needed in order to achieve suspend to RAM on this platform. > > Thanks, > Miquèl > Any inputs on this series? It is important for me because it impacts SATA, PCIe and USB changes I plan to get merge. Thanks, Miquèl > > Changes since v4: > ================= > * Fixed error in the driver probe where PHY_INTERFACE_MODE_NA was > assigned to lane->mode instead of lane->submode. > * Compile-in the driver by default (depends on ARCH_MVEBU). > * Add dependency on HAVE_ARM_SMCC in Kconfig. > > Changes since v3: > ================= > * Added Rob's Reviewed-by tag on bindings. > * Rebased on top of phy -next as of the 12th of December, 2018. > * Adapted the driver to support SGMII/1000BASEX and > HS_SGMII/2500BASEX. > > Changes since v2: > ================= > * Remove redundant check on lane->port/args->arg[0] at the end of the > ->xlate() callback. Do it on both armada-cp110 and armada-a3700 > COMPHY drivers. > * Put my SoB as author of the patch first when a patch is co-developed. > > Changes since v1: > ================= > * Fix wrong check in ->xlate(). > * Apply the same fix to the cp110 comphy driver from which the a3700 > driver is based. > * Added credit to Gregorz Jaszczyk for his work. > * Added Suggested-by tag to the patch adding the COMPHY DT node. > > > Grzegorz Jaszczyk (1): > phy: enumerate SATA PHY mode > > Miquel Raynal (6): > phy: mvebu-cp110-comphy: fix port check in ->xlate() > phy: add A3700 COMPHY support > dt-bindings: phy: mvebu-comphy: extend the file to describe a3700 > bindings > MAINTAINERS: phy: add entry for Armada 3700 COMPHY driver > ARM64: dts: marvell: armada-37xx: fix SATA node scope > ARM64: dts: marvell: armada-37xx: declare the COMPHY node > > .../bindings/phy/phy-mvebu-comphy.txt | 65 +++- > MAINTAINERS | 6 + > arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 31 +- > drivers/phy/marvell/Kconfig | 12 + > drivers/phy/marvell/Makefile | 1 + > drivers/phy/marvell/phy-mvebu-a3700-comphy.c | 318 ++++++++++++++++++ > drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 2 - > include/linux/phy/phy.h | 1 + > 8 files changed, 421 insertions(+), 15 deletions(-) > create mode 100644 drivers/phy/marvell/phy-mvebu-a3700-comphy.c >