From: Thierry Reding <treding@nvidia.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpu: host1x: Use direct DMA with IOMMU API usage
Date: Thu, 7 Feb 2019 09:51:31 +0100 [thread overview]
Message-ID: <20190207085129.GB8741@ulmo> (raw)
In-Reply-To: <20190206220833.GA20747@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]
On Wed, Feb 06, 2019 at 02:08:33PM -0800, Guenter Roeck wrote:
> On Fri, Feb 01, 2019 at 02:28:26PM +0100, Thierry Reding wrote:
> > If we use the IOMMU API directly to map buffers into host1x' IOVA space,
> > we must make sure that the DMA API doesn't already set up a mapping, or
> > else translation will fail.
> >
> > The direct DMA API allows us to allocate memory that will not be mapped
> > through an IOMMU automatically.
> >
> > Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
>
> arm64:defconfig:
>
> ERROR: "dma_direct_free" [drivers/gpu/host1x/host1x.ko] undefined!
> ERROR: "dma_direct_alloc" [drivers/gpu/host1x/host1x.ko] undefined!
Hi Guenter,
I sent out a fix to export dma_direct_alloc() and dma_direct_free() but
Christoph preferred not to merge that, so I'm currently working on a
different solution for this. I hope to have a fix for this by the end of
the day, but if not I'll back out the above commit.
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-02-07 8:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 22:08 [PATCH] gpu: host1x: Use direct DMA with IOMMU API usage Guenter Roeck
2019-02-07 8:51 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207085129.GB8741@ulmo \
--to=treding@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox