Re: [PATCH] mfd: tps68470: drop unused MODULE_DEVICE_TABLE

Lee Jones
2019-02-07T09:51:22Z

On Wed, 06 Feb 2019, Paul Gortmaker wrote:

> The Kconfig currently controlling compilation of this code is:
>
> drivers/mfd/Kconfig:config MFD_TPS68470
> drivers/mfd/Kconfig: bool "TI TPS68470 Power Management / LED chips"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Hence we remove the MODULE_DEVICE_TABLE since it is a no-op for
> non-modular code.
>
> There is no removal of <linux/module.h> here because there isn't one.
> Instead, it is relying on including that implicitly from an ACPI header.
>
> In cleaning up the ACPI instance of module.h (which also isn't strictly
> needed), then this mfd driver breaks when MODULE_DEVICE_TABLE becomes
> undefined here.
>
> The easiest dependency solution is to simply defer the ACPI cleanup
> until this change is present in mainline.
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Applied, thanks.

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog