Re: [PATCH] serial: Add Tegra Combined UART driver

[Thierry Reding <treding@nvidia.com>]

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

On Thu, Feb 07, 2019 at 06:39:16AM -0800, Guenter Roeck wrote:
> On Wed, Jan 23, 2019 at 11:28:19AM +0100, Thierry Reding wrote:
> > The Tegra Combined UART (TCU) is a mailbox-based mechanism that allows
> > multiplexing multiple "virtual UARTs" into a single hardware serial
> > port. The TCU is the primary serial port on Tegra194 devices.
> > 
> > Add a TCU driver utilizing the mailbox framework, as the used mailboxes
> > are part of Tegra HSP blocks that are already controlled by the Tegra
> > HSP mailbox driver.
> > 
> > Based on work by  Mikko Perttunen <mperttunen@nvidia.com>.
> > 
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> In case 0day hasn't reported it:
> 
> arm64:allmodconfig:
> 
> ERROR: "mbox_flush" [drivers/tty/serial/tegra-tcu.ko] undefined!
> 
> mbox_flush() isn't exported.

We only ever test TCU as built-in because it's used for the system
console, so I never actually tested this as a module. I sent a fix
for this earlier this week:

	https://lore.kernel.org/patchwork/patch/1038464/

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]