From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81F18C282C2 for ; Thu, 7 Feb 2019 22:20:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56A1E2147C for ; Thu, 7 Feb 2019 22:20:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726896AbfBGWUe convert rfc822-to-8bit (ORCPT ); Thu, 7 Feb 2019 17:20:34 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:51797 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726576AbfBGWUd (ORCPT ); Thu, 7 Feb 2019 17:20:33 -0500 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 2FA8F100003; Thu, 7 Feb 2019 22:20:29 +0000 (UTC) Date: Thu, 7 Feb 2019 23:20:28 +0100 From: Miquel Raynal To: Dinh Nguyen Cc: Boris Brezillon , Richard Weinberger , Masahiro Yamada , Marek Vasut , Linux Kernel Mailing List , Boris Brezillon , linux-mtd , Brian Norris , David Woodhouse Subject: Re: [PATCH] mtd: rawnand: denali_dt: remove single anonymous clock support Message-ID: <20190207232028.26b4a7f5@xps13> In-Reply-To: References: <1547539894-12898-1-git-send-email-yamada.masahiro@socionext.com> <20190115092229.59e09c2d@xps13> <20190128112007.440046e6@xps13> <20190131182644.366a54a5@bbrezillon> <20190205141853.4b7ed954@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dinh, Dinh Nguyen wrote on Thu, 7 Feb 2019 12:17:50 -0600: > On 2/5/19 7:18 AM, Miquel Raynal wrote: > > Hi Dinh, > > > > Boris Brezillon wrote on Thu, 31 Jan 2019 > > 18:26:44 +0100: > > > >> Hi Dinh, > >> > >> On Thu, 31 Jan 2019 11:24:16 -0600 > >> Dinh Nguyen wrote: > >> > >>> On 1/28/19 4:20 AM, Miquel Raynal wrote: > >>>> Hi Dinh, > >>>> > >>>> Masahiro Yamada wrote on Wed, 16 Jan > >>>> 2019 10:27:11 +0900: > >>>> > >>>>> (+CC Dinh Nguyen) > >>>>> > >>>>> On Tue, Jan 15, 2019 at 5:22 PM Miquel Raynal wrote: > >>>>>> > >>>>>> Hi Masahiro, > >>>>>> > >>>>>> Masahiro Yamada wrote on Tue, 15 Jan > >>>>>> 2019 17:11:34 +0900: > >>>>>> > >>>>>>> Commit 6f1fe97bec34 ("mtd: rawnand: denali_dt: add more clocks based > >>>>>>> on IP datasheet") introduced a more correct binding that requires > >>>>>>> three named clocks. > >>>>>>> > >>>>>>> Now that all upstream DT files migrated over to it, remove the single > >>>>>>> anonymous clock support. > >>>>>> > >>>>>> I would love to do that but I think this is against the "DT backward > >>>>>> compatibility rule". > >>>>> > >>>>> Yeah, I know this rule, but we break DT binding from time to time. > >>>>> > >>>>> > >>>>> > >>>>>> Anyway, IIRC it is accepted that this kind of > >>>>>> rule might be broken if decided per the arch-maintainer (in this > >>>>>> case, you I suppose). So if this is really what you want, I'll queue > >>>>>> it. > >>>>> > >>>>> My platform is fine, but this driver is used by SOCFPGA boards as well. > >>>>> > >>>>> I CCed the SOCFPGA maintainer, Dinh Nguyen. > >>>>> > >>>> > >>>> Gentle ping on this topic. > >>>> > >>> > >>> This patch looks fine to be. Feel free to add: > >>> > >>> Tested-by: Dinh Nguyen > >> > >> I think Miquel is waiting for an Acked-by to confirm that you're okay > >> breaking backward compat with old DT. > > > > Yes, I am waiting for your Acked-by. > > > > > > Acked-by: Dinh Nguyen > > Dinh Applied to nand/next. Thanks, Miquèl