From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E946C282CB for ; Fri, 8 Feb 2019 04:43:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3488321916 for ; Fri, 8 Feb 2019 04:43:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726943AbfBHEnH (ORCPT ); Thu, 7 Feb 2019 23:43:07 -0500 Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:31792 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726793AbfBHEnG (ORCPT ); Thu, 7 Feb 2019 23:43:06 -0500 Received: from ppp59-167-129-252.static.internode.on.net (HELO dastard) ([59.167.129.252]) by ipmail06.adl6.internode.on.net with ESMTP; 08 Feb 2019 15:13:03 +1030 Received: from dave by dastard with local (Exim 4.80) (envelope-from ) id 1gry0E-0005Lj-8g; Fri, 08 Feb 2019 15:43:02 +1100 Date: Fri, 8 Feb 2019 15:43:02 +1100 From: Dave Chinner To: Christopher Lameter Cc: Doug Ledford , Dan Williams , Jason Gunthorpe , Matthew Wilcox , Jan Kara , Ira Weiny , lsf-pc@lists.linux-foundation.org, linux-rdma , Linux MM , Linux Kernel Mailing List , John Hubbard , Jerome Glisse , Michal Hocko Subject: Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA Message-ID: <20190208044302.GA20493@dastard> References: <20190206173114.GB12227@ziepe.ca> <20190206175233.GN21860@bombadil.infradead.org> <47820c4d696aee41225854071ec73373a273fd4a.camel@redhat.com> <01000168c43d594c-7979fcf8-b9c1-4bda-b29a-500efe001d66-000000@email.amazonses.com> <20190206210356.GZ6173@dastard> <20190206220828.GJ12227@ziepe.ca> <0c868bc615a60c44d618fb0183fcbe0c418c7c83.camel@redhat.com> <01000168c8e2de6b-9ab820ed-38ad-469c-b210-60fcff8ea81c-000000@email.amazonses.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01000168c8e2de6b-9ab820ed-38ad-469c-b210-60fcff8ea81c-000000@email.amazonses.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 07, 2019 at 04:55:37PM +0000, Christopher Lameter wrote: > One approach that may be a clean way to solve this: > 3. Filesystems that allow bypass of the page cache (like XFS / DAX) will > provide the virtual mapping when the PIN is done and DO NO OPERATIONS > on the longterm pinned range until the long term pin is removed. So, ummm, how do we do block allocation then, which is done on demand during writes? IOWs, this requires the application to set up the file in the correct state for the filesystem to lock it down so somebody else can write to it. That means the file can't be sparse, it can't be preallocated (i.e. can't contain unwritten extents), it must have zeroes written to it's full size before being shared because otherwise it exposes stale data to the remote client (secure sites are going to love that!), they can't be extended, etc. IOWs, once the file is prepped and leased out for RDMA, it becomes an immutable for the purposes of local access. Which, essentially we can already do. Prep the file, map it read/write, mark it immutable, then pin it via the longterm gup interface which can do the necessary checks. Simple to implement, the reasons for errors trying to modify the file are already documented and queriable, and it's hard for applications to get wrong. Cheers, Dave. -- Dave Chinner david@fromorbit.com