From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC514C282CB for ; Sat, 9 Feb 2019 18:53:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A77BF20821 for ; Sat, 9 Feb 2019 18:53:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549738407; bh=SQbUFCd+lKqKv/YYgzC/1cplw2hLs+9BnMUw0YhjiOI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Infj5A7NOQWWW7ITigNkZC8kQ4hVboM5PPFvw79Qng6qPyT4+8u9PZOFO+8tUgBVW 4ASsnP/IwaZQb1w3bQN7f8/xOTfNh3gSywp7+FacH5IqTRO1hARLKr8YG4lha/viIp 46HTsH65ecWa233wJnmNZM6E7m6dfWx1YQ4WqvKs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728083AbfBIStV (ORCPT ); Sat, 9 Feb 2019 13:49:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:34752 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728067AbfBIStS (ORCPT ); Sat, 9 Feb 2019 13:49:18 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0B61F21919; Sat, 9 Feb 2019 18:49:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549738158; bh=SQbUFCd+lKqKv/YYgzC/1cplw2hLs+9BnMUw0YhjiOI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JvXyCrea7duX0wmtFl1ewY1yoint2Hqfug+aOzFYKhJFkla6/VXAGNxoe64/1paXy bIfxY2/gd0FXqXWYpmXvIeG0z6YZKjshdPIPQjq1Q3RCGN2cVabIG753EFr0ktrBvt X9Q+V/fN5bEzR2+zxKKHZD7/fjzMxLZXMGfzaGXI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Linus Walleij , Jamie Lentin , Guenter Roeck , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Julien D'Ascenzio , Sasha Levin , devicetree@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 23/28] ARM: dts: kirkwood: Fix polarity of GPIO fan lines Date: Sat, 9 Feb 2019 13:48:31 -0500 Message-Id: <20190209184840.126418-23-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190209184840.126418-1-sashal@kernel.org> References: <20190209184840.126418-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linus Walleij [ Upstream commit b5f034845e70916fd33e172fad5ad530a29c10ab ] These two lines are active high, not active low. The bug was found when we changed the kernel to respect the polarity defined in the device tree. Fixes: 1b90e06b1429 ("ARM: kirkwood: Use devicetree to define DNS-32[05] fan") Cc: Jamie Lentin Cc: Guenter Roeck Cc: Jason Cooper Cc: Andrew Lunn Cc: Gregory Clement Cc: Sebastian Hesselbarth Cc: Julien D'Ascenzio Reviewed-by: Andrew Lunn Tested-by: Jamie Lentin Reported-by: Julien D'Ascenzio Tested-by: Julien D'Ascenzio Signed-off-by: Linus Walleij Signed-off-by: Gregory CLEMENT Signed-off-by: Sasha Levin --- arch/arm/boot/dts/kirkwood-dnskw.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/kirkwood-dnskw.dtsi b/arch/arm/boot/dts/kirkwood-dnskw.dtsi index cbaf06f2f78e..eb917462b219 100644 --- a/arch/arm/boot/dts/kirkwood-dnskw.dtsi +++ b/arch/arm/boot/dts/kirkwood-dnskw.dtsi @@ -36,8 +36,8 @@ compatible = "gpio-fan"; pinctrl-0 = <&pmx_fan_high_speed &pmx_fan_low_speed>; pinctrl-names = "default"; - gpios = <&gpio1 14 GPIO_ACTIVE_LOW - &gpio1 13 GPIO_ACTIVE_LOW>; + gpios = <&gpio1 14 GPIO_ACTIVE_HIGH + &gpio1 13 GPIO_ACTIVE_HIGH>; gpio-fan,speed-map = <0 0 3000 1 6000 2>; -- 2.19.1