From: Ingo Molnar <mingo@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@amacapital.net>,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 1/2] selftests/x86/fsgsbase: Indirect output through a wrapper function
Date: Mon, 11 Feb 2019 09:45:43 +0100 [thread overview]
Message-ID: <20190211084543.GA62722@gmail.com> (raw)
In-Reply-To: <20190203134017.9375-2-broonie@kernel.org>
* Mark Brown <broonie@kernel.org> wrote:
> In preparation for a change to make this test run repeatedly which
> would generate huge amounts of output as is indirect all the printf()
> calls in the program through a wrapper and add a quiet flag which can
> be used to suppress the output. This is fairly quick and dirty, I'm not
> 100% sure what would be idiomatic here.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> tools/testing/selftests/x86/fsgsbase.c | 52 ++++++++++++++++----------
> 1 file changed, 32 insertions(+), 20 deletions(-)
So this really loses useful output when there is a failure. After this
patch I get:
dagon:~/tip/tools/testing/selftests/x86> ./fsgsbase_64 -vv
[FAIL] 24 errors detected in 1 tries
Not very helpful, and no real command-line way to see the failures.
While previously it would tell me what's going on:
dagon:~/tip/tools/testing/selftests/x86> ./fsgsbase_64 | grep FAIL
[FAIL] GS/BASE changed from 0x1/0x1 to 0x1/0x0
[FAIL] GS/BASE changed from 0x2/0x1 to 0x2/0x0
[FAIL] GS/BASE changed from 0x3/0x1 to 0x3/0x0
[FAIL] GS/BASE changed from 0x1/0x1 to 0x1/0x0
[FAIL] GS/BASE changed from 0x2/0x1 to 0x2/0x0
[FAIL] GS/BASE changed from 0x3/0x1 to 0x3/0x0
[FAIL] GS/BASE changed from 0x1/0x1 to 0x1/0x0
[FAIL] GS/BASE changed from 0x2/0x1 to 0x2/0x0
[FAIL] GS/BASE changed from 0x3/0x1 to 0x3/0x0
[FAIL] GS/BASE changed from 0x1/0x1 to 0x1/0x0
[FAIL] GS/BASE changed from 0x2/0x1 to 0x2/0x0
[FAIL] GS/BASE changed from 0x3/0x1 to 0x3/0x0
[FAIL] GS/BASE changed from 0x1/0x200000000 to 0x1/0x0
[FAIL] GS/BASE changed from 0x2/0x200000000 to 0x2/0x0
[FAIL] GS/BASE changed from 0x3/0x200000000 to 0x3/0x0
[FAIL] GS/BASE changed from 0x1/0x200000000 to 0x1/0x0
[FAIL] GS/BASE changed from 0x2/0x200000000 to 0x2/0x0
[FAIL] GS/BASE changed from 0x3/0x200000000 to 0x3/0x0
[FAIL] GS/BASE changed from 0x1/0x200000000 to 0x1/0x0
[FAIL] GS/BASE changed from 0x2/0x200000000 to 0x2/0x0
[FAIL] GS/BASE changed from 0x3/0x200000000 to 0x3/0x0
[FAIL] GS/BASE changed from 0x1/0x200000000 to 0x1/0x0
[FAIL] GS/BASE changed from 0x2/0x200000000 to 0x2/0x0
[FAIL] GS/BASE changed from 0x3/0x200000000 to 0x3/0x0
So I believe at least failure messages need to be preserved.
Thanks,
Ingo
next prev parent reply other threads:[~2019-02-11 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-03 13:40 [PATCH 0/2] Make fsgsbase test more stable Mark Brown
2019-02-03 13:40 ` [PATCH 1/2] selftests/x86/fsgsbase: Indirect output through a wrapper function Mark Brown
2019-02-11 8:45 ` Ingo Molnar [this message]
2019-02-11 13:02 ` Mark Brown
2019-02-03 13:40 ` [PATCH 2/2] selftests/x86/fsgsbase: Default to trying to run the test repeatedly Mark Brown
2019-02-11 8:49 ` Ingo Molnar
2019-02-11 12:47 ` Mark Brown
2019-02-11 12:51 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211084543.GA62722@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox