From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Dmitry Torokhov <dtor@chromium.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Enrico Granata <egranata@google.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Gwendal Grignou <gwendal@chromium.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Brian Norris <briannorris@chromium.org>,
Enrico Granata <egranata@chromium.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] driver: platform: Add support for GpioInt() ACPI to platform_get_irq()
Date: Mon, 11 Feb 2019 12:30:24 +0200 [thread overview]
Message-ID: <20190211103024.GY7875@lahna.fi.intel.com> (raw)
In-Reply-To: <CAE_wzQ_RLC7N=jzj693d42T4K-CtSA-ckavt1FNDFZmLcXkB6w@mail.gmail.com>
Hi,
On Thu, Feb 07, 2019 at 12:29:17PM -0800, Dmitry Torokhov wrote:
> >
> > > Do you have a suggestion as to how to write ACPI tables to avoid the issue?
> >
> > 1. Allocate new ID and use it (perhaps not the best path).
> > 2. Use GPE(s).
> >
>
> Or just solve the issue of intermixing Interrupt() with GpioInt(). We
> have similar issue with i2c and spi, but we sidestep that there as we
> only parse the first interrupt and do not give option of fetching 2nd,
> 3rd, etc. Maybe we should only GpioInt parsing for the first interrupt
> in platform_get_irq() as well for the first iteration and then see if
> we need to improve it if we see devices with multiple interrupts.
I think it should be fine to intermix them or do what you suggest and
start supporting index 0 for now and then maybe extend it in the future
to cover more.
next prev parent reply other threads:[~2019-02-11 10:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 18:59 [PATCH] driver: platform: Add support for GpioInt() ACPI to platform_get_irq() egranata
2019-02-07 19:02 ` Rafael J. Wysocki
2019-02-07 19:39 ` Andy Shevchenko
2019-02-07 19:45 ` Andy Shevchenko
2019-02-07 19:55 ` Enrico Granata
[not found] ` <CAPR809vnpuh8nOjU3QMCh6YJUKmtX92+bnHSUKGiAXAp6NwCHQ@mail.gmail.com>
2019-02-07 20:18 ` Andy Shevchenko
2019-02-07 20:29 ` Dmitry Torokhov
2019-02-11 10:30 ` Mika Westerberg [this message]
2019-02-11 15:42 ` Hans de Goede
2019-02-11 19:01 ` [PATCH v2] driver: platform: Support parsing GpioInt 0 in platform_get_irq() egranata
2019-02-11 19:25 ` Dmitry Torokhov
2019-02-12 7:29 ` Hans de Goede
2019-02-12 9:08 ` Mika Westerberg
2019-02-12 9:18 ` Rafael J. Wysocki
2019-02-12 12:46 ` Andy Shevchenko
2019-02-20 18:05 ` Brian Norris
2019-02-21 18:58 ` Enrico Granata
2019-02-21 19:34 ` [PATCH v3] " egranata
2019-02-22 9:03 ` Rafael J. Wysocki
2019-02-22 17:06 ` Brian Norris
2019-02-24 19:34 ` [PATCH v2] " Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2019-02-07 18:50 [PATCH] driver: platform: Add support for GpioInt() ACPI to platform_get_irq() egranata
2019-02-07 18:57 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211103024.GY7875@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=briannorris@chromium.org \
--cc=dtor@chromium.org \
--cc=egranata@chromium.org \
--cc=egranata@google.com \
--cc=enric.balletbo@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=gwendal@chromium.org \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox