From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AACEC169C4 for ; Mon, 11 Feb 2019 15:15:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE443222A8 for ; Mon, 11 Feb 2019 15:15:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549898157; bh=taayahmU25J/e4dGCWqIjKRtUqp/czGZov06HAhEIp4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YPvHTWGvm1MOHcqv6LTNnNgZq3Sd4ZQmfSA8V8CrfkspYJkmElpz3DOZ3SV0SrWMi eAt0k7bd7/eykY8BvE9VaIrtSeWmNmspVJQel753HpJaPK76ULDSu6LUjbg7dH/8CZ dxq/XKyKzLlPMAq+DZclOzTjXRMpPB0SFbWMnJbI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391351AbfBKPHa (ORCPT ); Mon, 11 Feb 2019 10:07:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:57202 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731524AbfBKPHZ (ORCPT ); Mon, 11 Feb 2019 10:07:25 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F30D2217D9; Mon, 11 Feb 2019 15:07:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549897644; bh=taayahmU25J/e4dGCWqIjKRtUqp/czGZov06HAhEIp4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RnbhpX7f08Z3kIKZ4fpP5NHi4wzIrX/SaMZE1hfOqFRWl4zpboJG/zh2dneE90kmK Ti2qzHwRYotRwkmOemyv2A/wlpJsyAgLJqG99loeilhrSNwECSfunMiMsFRm2DYDmy pGz4Dh13ZiNpikbz57DGlVvNcYvoD1apBQGqgRBs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Murthy Bhat , Mahesh Rajashekhara , Scott Teel , Kevin Barnett , Dave Carroll , Don Brace , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.9 066/137] scsi: smartpqi: correct volume status Date: Mon, 11 Feb 2019 15:19:07 +0100 Message-Id: <20190211141818.115114357@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141811.964925535@linuxfoundation.org> References: <20190211141811.964925535@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 7ff44499bafbd376115f0bb6b578d980f56ee13b ] - fix race condition when a unit is deleted after an RLL, and before we have gotten the LV_STATUS page of the unit. - In this case we will get a standard inquiry, rather than the desired page. This will result in a unit presented which no longer exists. - If we ask for LV_STATUS, insure we get LV_STATUS Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Dave Carroll Signed-off-by: Don Brace Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/smartpqi/smartpqi_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index 9a208961cc0b..06a062455404 100644 --- a/drivers/scsi/smartpqi/smartpqi_init.c +++ b/drivers/scsi/smartpqi/smartpqi_init.c @@ -983,6 +983,9 @@ static void pqi_get_volume_status(struct pqi_ctrl_info *ctrl_info, if (rc) goto out; + if (vpd->page_code != CISS_VPD_LV_STATUS) + goto out; + page_length = offsetof(struct ciss_vpd_logical_volume_status, volume_status) + vpd->page_length; if (page_length < sizeof(*vpd)) -- 2.19.1