From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A11D9C169C4 for ; Mon, 11 Feb 2019 17:11:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 701DA2082F for ; Mon, 11 Feb 2019 17:11:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549905095; bh=ErKWt0KHUNUfeZ7+bpoLEWio5pL4SoqDtrH6zt0hoAE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=EO8VY+u++/KZYI3Hws7FjuT2I4b8tT6jW+BbBSPSqORZB7NjjuTLAejYm45UJCbA8 cHyR1rbG/GMgvksS60dVas08M1MzP4qcU9FCaz4X8oU9lcvtOrj+Sfnu8uADaQdT4L FqG8hyXTSEb0wl40DciHT/icZRpJ7f69xofnLucg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730282AbfBKRLe (ORCPT ); Mon, 11 Feb 2019 12:11:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:34520 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726244AbfBKRLd (ORCPT ); Mon, 11 Feb 2019 12:11:33 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6AEF22082F; Mon, 11 Feb 2019 17:11:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549905092; bh=ErKWt0KHUNUfeZ7+bpoLEWio5pL4SoqDtrH6zt0hoAE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CsxKV/i7T9vtLcIWEa2tG7tgyku9yP8c7f19f7n23n3BMc14Jg1x/WevcpgvcQsPa j/WypSQaThcZ9biadz7gDKMi87jw4I048x17vdi/O9NED8utMA/tU12viM4gntdi8g HHJf1roCfVGV80eDU6lzKYEfpMYT1nGD9KmEmlLQ= Date: Mon, 11 Feb 2019 18:11:30 +0100 From: Greg KH To: Souptick Joarder Cc: devel@driverdev.osuosl.org, tkjos@android.com, linux-kernel@vger.kernel.org, arve@android.com, maco@android.com, christian@brauner.io Subject: Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT Message-ID: <20190211171130.GA13294@kroah.com> References: <20190211152602.GA5591@jordon-HP-15-Notebook-PC> <20190211154044.GA16105@kroah.com> <20190211155734.GA18078@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 11, 2019 at 10:15:18PM +0530, Souptick Joarder wrote: > On Mon, Feb 11, 2019 at 9:27 PM Greg KH wrote: > > > > On Mon, Feb 11, 2019 at 09:21:19PM +0530, Souptick Joarder wrote: > > > On Mon, Feb 11, 2019 at 9:10 PM Greg KH wrote: > > > > > > > > On Mon, Feb 11, 2019 at 08:56:02PM +0530, Souptick Joarder wrote: > > > > > As mentioned in TODO list, Removed VSOC_WAIT_FOR_INCOMING_INTERRUPT > > > > > ioctl. This functionality has been superseded by the futex and is > > > > > there for legacy reasons. > > > > > > > > > > Signed-off-by: Souptick Joarder > > > > > --- > > > > > drivers/staging/android/uapi/vsoc_shm.h | 7 ------- > > > > > drivers/staging/android/vsoc.c | 5 ----- > > > > > 2 files changed, 12 deletions(-) > > > > > > > > So userspace is all fixed up now and this ioctl can be dropped? Any > > > > pointers to the userspace commit that did this? > > > > > > I am not sure about user space part. > > > > Then we can not just delete the ioctl :) > > Agree, but where to verify the user space commit ? > Any pointer to the source code path ? Please work with the android developers to solve this. It should be in AOSP "somewhere" :( good luck, greg k-h