Re: [PATCH 5/9] perf, bpf: save bpf_prog_info in a rbtree in perf_env

Song Liu
2019-02-14T17:03:53Z

> On Feb 14, 2019, at 4:33 AM, Jiri Olsa <jolsa@redhat.com> wrote:
>
> On Fri, Feb 08, 2019 at 05:17:01PM -0800, Song Liu wrote:
>> bpf_prog_info contains information necessary to annotate bpf programs.
>> This patch saves bpf_prog_info for bpf programs loaded in the system.
>>
>> perf-record saves bpf_prog_info information as headers to perf.data.
>> A new header type HEADER_BPF_PROG_INFO is introduced for this data.
>
> please move those 2 changes into separate patches then

Do you mean one patch to save data in rbtree, then a separate patch
to save data in perf.data file?

Thanks,
Song

>
> it's hard to make comments when I don't see the rest of
> the patches on the list please resend the patchset
>
> thanks,
> jirka