public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Eduardo Valentin <edubezval@gmail.com>,
	pr-tracker-bot@kernel.org, Rui Zhang <rui.zhang@intel.com>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Linux PM <linux-pm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Thermal-SoC management fixes for v5.0-rc6
Date: Mon, 11 Feb 2019 15:16:19 -0500	[thread overview]
Message-ID: <20190211201619.GA8065@work> (raw)
In-Reply-To: <CAHk-=wgz_WpD7jc084QROuM0zszEG0-WvQhQZPsCboMOWNRiWw@mail.gmail.com>

On Mon, Feb 11, 2019 at 10:34:09AM -0800, Linus Torvalds wrote:
>> > > git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal 
>> > > fixes
>> >
>> > has been merged into torvalds/linux.git:
>> > https://git.kernel.org/torvalds/c/7ad915f5ebf5b9e7ca98a7048d8f84a631fe388b
>>
>> I think the bot is off here because the above commit is about a merge
>> from the linux-omap tree from Tony.
>
>Indeed.
>
>.. and the pr-tracker-bot thing actually made me ignore the pull
>request, thinking I had left it in my inbox despite having pulled it.
>
>So it would be really good to know why pr-tracker-bot ended up
>replying to the wrong email, because it can cause real problems.

Okay, so I need guidance on the proper behaviour here. As this request 
didn't use the magic wording for the commit-id (as generated by 
git-request-pull), we ended up trying to look up the remote. The remote 
specified was:

  git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal fixes

Since it's a short refname, we first try to look it up as a tag:

$ git ls-remote git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal fixes^{}
a6d25f4c951b8b28f2eaec6f891ff834622532f2        refs/tags/omap-for-v3.10-rc1/fixes^{}
77319669af37a1cfc844b801e83343b37e3c7e13        refs/tags/omap/fixes^{}

If it finds a matching tag, the script assumes you'd meant to specify 
the tag, not the head. Is that the opposite of git's behaviour when 
applying a remote? Should we be checking for a head first, before we try 
the refname as a tag? I assume that's the case, but want to double-check 
with you all.

-K

  parent reply	other threads:[~2019-02-11 20:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-10  4:17 [GIT PULL] Thermal-SoC management fixes for v5.0-rc6 Eduardo Valentin
2019-02-10  4:25 ` pr-tracker-bot
2019-02-11  3:19   ` Eduardo Valentin
2019-02-11 18:34     ` Linus Torvalds
2019-02-11 18:40       ` Konstantin Ryabitsev
2019-02-11 20:05         ` Konstantin Ryabitsev
2019-02-11 20:16       ` Konstantin Ryabitsev [this message]
2019-02-11 22:04         ` Linus Torvalds
2019-02-11 23:10           ` Konstantin Ryabitsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190211201619.GA8065@work \
    --to=konstantin@linuxfoundation.org \
    --cc=edubezval@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pr-tracker-bot@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox