From: Peter Seiderer <ps.report@gmx.net>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
b-ak <anur.bhargav@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
alsa-devel@alsa-project.org
Subject: Re: [RFC v1] tlv320aic32x4: delay i2c access by 1 ms after hardware reset
Date: Mon, 11 Feb 2019 22:02:30 +0100 [thread overview]
Message-ID: <20190211220230.7cd7b559@gmx.net> (raw)
In-Reply-To: <20190211150425.GE22391@sirena.org.uk>
Hello Mark,
On Mon, 11 Feb 2019 15:04:25 +0000, Mark Brown <broonie@kernel.org> wrote:
> On Sun, Feb 10, 2019 at 04:45:19PM +0100, Peter Seiderer wrote:
>
> > @@ -972,6 +972,8 @@ static int aic32x4_component_probe(struct snd_soc_component *component)
> > gpio_set_value(aic32x4->rstn_gpio, 1);
> > }
> >
> > + mdelay(1);
> > +
>
> Perhaps only do this if we toggled the GPIO? If the device wasn't in
> reset then there's no need to wait.
You are absolutely right with this, will re-spin the patch with
the suggested change, thanks for review...
Regards,
Peter
prev parent reply other threads:[~2019-02-11 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 15:45 [RFC v1] tlv320aic32x4: delay i2c access by 1 ms after hardware reset Peter Seiderer
2019-02-11 15:04 ` Mark Brown
2019-02-11 21:02 ` Peter Seiderer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211220230.7cd7b559@gmx.net \
--to=ps.report@gmx.net \
--cc=alsa-devel@alsa-project.org \
--cc=anur.bhargav@gmail.com \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox