Re: [PATCH v8 1/8] mfd: regulator: clk: split rohm-bd718x7.h

Lee Jones
2019-02-07T11:41:10Z

On Thu, 07 Feb 2019, Matti Vaittinen wrote:

> Split the bd718x7.h to ROHM common and bd718x7 specific parts
> so that we do not need to add same things in every new ROHM
> PMIC header. Please note that this change requires changes also
> in bd718x7 sub-device drivers for regulators and clk.
>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> Acked-by: Mark Brown <broonie@kernel.org>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
> ---
>
> Please note that I maintained the acks from Mark and Stephen even
> though this is a squash of 3 commits and both Mark and Stephen had
> only acked one of the patches. (The patch which touched their area
> clk for Stephen, regulators for Mark). I interpreted their acks as
> 'the split is in general Ok and portion I am interested in is fine'
> and thus maintained the acks. Please let me know if this is not Ok.
>
> drivers/clk/clk-bd718x7.c | 6 +++---
> drivers/mfd/rohm-bd718x7.c | 23 ++++++++++++-----------
> drivers/regulator/bd718x7-regulator.c | 24 ++++++++++++------------
> include/linux/mfd/rohm-bd718x7.h | 22 ++++++++--------------
> include/linux/mfd/rohm-generic.h | 20 ++++++++++++++++++++
> 5 files changed, 55 insertions(+), 40 deletions(-)
> create mode 100644 include/linux/mfd/rohm-generic.h

For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog