From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 621C5C282C4 for ; Tue, 12 Feb 2019 13:09:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39C62214DA for ; Tue, 12 Feb 2019 13:09:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729727AbfBLNJS (ORCPT ); Tue, 12 Feb 2019 08:09:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56164 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728827AbfBLNJR (ORCPT ); Tue, 12 Feb 2019 08:09:17 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5BF8889ACD; Tue, 12 Feb 2019 13:09:17 +0000 (UTC) Received: from krava (unknown [10.43.17.136]) by smtp.corp.redhat.com (Postfix) with SMTP id B22C06019F; Tue, 12 Feb 2019 13:09:15 +0000 (UTC) Date: Tue, 12 Feb 2019 14:09:14 +0100 From: Jiri Olsa To: Alexey Budankov Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Namhyung Kim , Alexander Shishkin , Andi Kleen , linux-kernel Subject: Re: [PATCH v2 4/4] perf report: support record trace file decompression Message-ID: <20190212130914.GK775@krava> References: <044ee2be-2e1d-e90f-7317-40083b5e716c@linux.intel.com> <4f45c930-cf39-76b0-5c56-ee4fb0705fa3@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f45c930-cf39-76b0-5c56-ee4fb0705fa3@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 12 Feb 2019 13:09:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 11, 2019 at 11:25:00PM +0300, Alexey Budankov wrote: > > PERF_RECORD_COMPRESSED records are decompressed from trace file into > a linked list of mmaped memory regions using streaming Zstandard API. > After that the regions are loaded fetching uncompressed events. When > dumping raw trace (e.g., perf report -D --header) file offsets of > events from compressed records are set to zero. > > Signed-off-by: Alexey Budankov > --- > Changes in v2: > - moved compression/decompression code to session layer could you please add some automated test for this? I think it could be part of the sample synthesize test or even new script test under tests/shell.. or anything else really.. just to see that we have some clean interface for this that we can test thanks, jirka