From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CE9CC282C4 for ; Tue, 12 Feb 2019 13:09:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E99F2214DA for ; Tue, 12 Feb 2019 13:09:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729787AbfBLNJq (ORCPT ); Tue, 12 Feb 2019 08:09:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55916 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728631AbfBLNJo (ORCPT ); Tue, 12 Feb 2019 08:09:44 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6FFEFC0669C2; Tue, 12 Feb 2019 13:09:44 +0000 (UTC) Received: from krava (unknown [10.43.17.136]) by smtp.corp.redhat.com (Postfix) with SMTP id BD21860C1C; Tue, 12 Feb 2019 13:09:42 +0000 (UTC) Date: Tue, 12 Feb 2019 14:09:41 +0100 From: Jiri Olsa To: Alexey Budankov Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Namhyung Kim , Alexander Shishkin , Andi Kleen , linux-kernel Subject: Re: [PATCH v2 2/4] perf record: implement -z= and --mmap-flush= options Message-ID: <20190212130941.GP775@krava> References: <044ee2be-2e1d-e90f-7317-40083b5e716c@linux.intel.com> <2d676199-bfe0-d8e0-442e-41280046f819@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2d676199-bfe0-d8e0-442e-41280046f819@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 12 Feb 2019 13:09:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 11, 2019 at 11:22:38PM +0300, Alexey Budankov wrote: SNIP > +static int process_compressed(struct feat_fd *ff, > + void *data __maybe_unused) > +{ > + u64 compression_info; > + > + if (do_read_u64(ff, &compression_info)) > + return -1; > + > + ff->ph->env.comp_type = (compression_info >> 32) & 0xffffffffULL; > + ff->ph->env.comp_level = compression_info & 0xffffffffULL; > + > + if (do_read_u64(ff, &compression_info)) > + return -1; > + > + ff->ph->env.comp_ratio = (compression_info >> 32) & 0xffffffffULL; > + ff->ph->env.comp_mmap_len = compression_info & 0xffffffffULL; > + > + return 0; > +} > + > struct feature_ops { > int (*write)(struct feat_fd *ff, struct perf_evlist *evlist); > void (*print)(struct feat_fd *ff, FILE *fp); > @@ -2651,7 +2693,8 @@ static const struct feature_ops feat_ops[HEADER_LAST_FEATURE] = { > FEAT_OPN(CACHE, cache, true), > FEAT_OPR(SAMPLE_TIME, sample_time, false), > FEAT_OPR(MEM_TOPOLOGY, mem_topology, true), > - FEAT_OPR(CLOCKID, clockid, false) > + FEAT_OPR(CLOCKID, clockid, false), > + FEAT_OPR(COMPRESSED, compressed, false) please separate the COMPRESSED feature ddition into single patch thanks, jirka