From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F601C282C4 for ; Tue, 12 Feb 2019 17:31:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 08E9720821 for ; Tue, 12 Feb 2019 17:31:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730914AbfBLRbk (ORCPT ); Tue, 12 Feb 2019 12:31:40 -0500 Received: from mga12.intel.com ([192.55.52.136]:62439 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728066AbfBLRbj (ORCPT ); Tue, 12 Feb 2019 12:31:39 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Feb 2019 09:31:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,362,1544515200"; d="scan'208";a="114355454" Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by orsmga007.jf.intel.com with ESMTP; 12 Feb 2019 09:31:38 -0800 Date: Tue, 12 Feb 2019 10:31:20 -0700 From: Keith Busch To: Jonathan Cameron Cc: Brice Goglin , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , Greg Kroah-Hartman , Rafael Wysocki , "Hansen, Dave" , "Williams, Dan J" Subject: Re: [PATCHv4 10/13] node: Add memory caching attributes Message-ID: <20190212173120.GD6176@localhost.localdomain> References: <20190116175804.30196-1-keith.busch@intel.com> <20190116175804.30196-11-keith.busch@intel.com> <4a7d1c0c-c269-d7b2-11cb-88ad62b70a06@inria.fr> <20190210171958.00003ab2@huawei.com> <20190211152303.GA4525@localhost.localdomain> <20190212084903.00003ff5@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190212084903.00003ff5@huawei.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 12, 2019 at 08:49:03AM +0000, Jonathan Cameron wrote: > On Mon, 11 Feb 2019 08:23:04 -0700 > Keith Busch wrote: > > > On Sun, Feb 10, 2019 at 09:19:58AM -0800, Jonathan Cameron wrote: > > > On Sat, 9 Feb 2019 09:20:53 +0100 > > > Brice Goglin wrote: > > > > > > > Hello Keith > > > > > > > > Could we ever have a single side cache in front of two NUMA nodes ? I > > > > don't see a way to find that out in the current implementation. Would we > > > > have an "id" and/or "nodemap" bitmask in the sidecache structure ? > > > > > > This is certainly a possible thing for hardware to do. > > > > > > ACPI IIRC doesn't provide any means of representing that - your best > > > option is to represent it as two different entries, one for each of the > > > memory nodes. Interesting question of whether you would then claim > > > they were half as big each, or the full size. Of course, there are > > > other possible ways to get this info beyond HMAT, so perhaps the interface > > > should allow it to be exposed if available? > > > > HMAT doesn't do this, but I want this interface abstracted enough from > > HMAT to express whatever is necessary. > > > > The CPU cache is the closest existing exported attributes to this, > > and they provide "shared_cpu_list". To that end, I can export a > > "shared_node_list", though previous reviews strongly disliked multi-value > > sysfs entries. :( > > > > Would shared-node symlinks capture the need, and more acceptable? > > My inclination is that it's better to follow an existing pattern than > invent a new one that breaks people's expectations. > > However, don't feel that strongly about it as long as the interface > is functional and intuitive. Okay, considering I'd have a difficult time testing such an interface since it doesn't apply to HMAT, and I've received only conflicting feedback on list attributes, I would prefer to leave this feature out of this series for now. I'm certainly not against adding it later.