RE: [v5 2/2] arm64: dts: lx2160a: add sata node support

Peng Ma
2019-02-11T06:47:55Z

>-----Original Message-----
>From: Shawn Guo <shawnguo@kernel.org>
>Sent: 2019年2月11日 13:39
>To: Peng Ma <peng.ma@nxp.com>
>Cc: axboe@kernel.dk; mark.rutland@arm.com; Andy Tang
><andy.tang@nxp.com>; devicetree@vger.kernel.org;
>linux-kernel@vger.kernel.org; Leo Li <leoyang.li@nxp.com>;
>linux-ide@vger.kernel.org; robh+dt@kernel.org;
>linux-arm-kernel@lists.infradead.org
>Subject: Re: [v5 2/2] arm64: dts: lx2160a: add sata node support
>
>On Mon, Feb 11, 2019 at 02:53:18AM +0000, Peng Ma wrote:
>>
>>
>> >-----Original Message-----
>> >From: Shawn Guo <shawnguo@kernel.org>
>> >Sent: 2019年2月1日 14:30
>> >To: Peng Ma <peng.ma@nxp.com>
>> >Cc: axboe@kernel.dk; robh+dt@kernel.org; mark.rutland@arm.com; Leo Li
>> ><leoyang.li@nxp.com>; linux-ide@vger.kernel.org;
>> >devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
>> >linux-arm-kernel@lists.infradead.org; Andy Tang <andy.tang@nxp.com>
>> >Subject: Re: [v5 2/2] arm64: dts: lx2160a: add sata node support
>> >
>> >On Fri, Jan 25, 2019 at 08:10:13AM +0000, Peng Ma wrote:
>> >> Add SATA device nodes for fsl-lx2160a and enable support for QDS
>> >> and RDB boards.
>> >>
>> >> Signed-off-by: Peng Ma <peng.ma@nxp.com>
>> >> ---
>> >> changed for V5:
>> >> - no change
>> >>
>> >> arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts | 16 +++++++
>> >> arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 16 +++++++
>> >> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 44
>> >+++++++++++++++++++++
>> >> 3 files changed, 76 insertions(+), 0 deletions(-)
>> >>
>> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
>> >> b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
>> >> index 99a22ab..1a5acf6 100644
>> >> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
>> >> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
>> >> @@ -95,6 +95,22 @@
>> >> };
>> >> };
>> >>
>> >> +&sata0 {
>> >> + status = "okay";
>> >> +};
>> >> +
>> >> +&sata1 {
>> >> + status = "okay";
>> >> +};
>> >> +
>> >> +&sata2 {
>> >> + status = "okay";
>> >> +};
>> >> +
>> >> +&sata3 {
>> >> + status = "okay";
>> >> +};
>> >> +
>> >> &uart0 {
>> >> status = "okay";
>> >> };
>> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
>> >> b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
>> >> index 6481e5f..5b6799e 100644
>> >> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
>> >> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
>> >> @@ -102,6 +102,22 @@
>> >> };
>> >> };
>> >>
>> >> +&sata0 {
>> >> + status = "okay";
>> >> +};
>> >> +
>> >> +&sata1 {
>> >> + status = "okay";
>> >> +};
>> >> +
>> >> +&sata2 {
>> >> + status = "okay";
>> >> +};
>> >> +
>> >> +&sata3 {
>> >> + status = "okay";
>> >> +};
>> >> +
>> >> &uart0 {
>> >> status = "okay";
>> >> };
>> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
>> >> b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
>> >> index a79f5c1..592034b 100644
>> >> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
>> >> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
>> >> @@ -671,6 +671,50 @@
>> >> status = "disabled";
>> >> };
>> >>
>> >> + sata0: sata@3200000 {
>> >> + compatible = "fsl,lx2160a-ahci";
>> >
>> >Has the kernel driver been patched to probe the compatible?
>> >
>> >Shawn
>> Yes, the driver patch is
>> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatc
>>
>hwork.ozlabs.org%2Fpatch%2F1034083%2F&amp;data=02%7C01%7Cpeng.ma
>%40nxp
>> .com%7C8daea4e4b2ea419cb2a008d68fe34f51%7C686ea1d3bc2b4c6fa92c
>d99c5c30
>>
>1635%7C0%7C0%7C636854603794170576&amp;sdata=z3ic8%2FAS10NcFjdP
>eJFpnFoo
>> R2Yo4oYO%2FAASr7r2Lhg%3D&amp;reserved=0
>
>Ping me when the driver patch is accepted. Ideally, we only accept dts
>changes after the driver counterpart lands on mainline.
>
>Shawn
[Peng Ma] got it, thanks.
BR
Peng