From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] xen: mark expected switch fall-through
Date: Tue, 12 Feb 2019 18:50:41 -0500 [thread overview]
Message-ID: <20190212235041.GA4463@localhost.localdomain> (raw)
In-Reply-To: <20190212203720.GA24175@embeddedor>
On Tue, Feb 12, 2019 at 02:37:20PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/xen/xen-pciback/xenbus.c: In function ‘xen_pcibk_frontend_changed’:
> drivers/xen/xen-pciback/xenbus.c:545:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (xenbus_dev_is_online(xdev))
> ^
> drivers/xen/xen-pciback/xenbus.c:548:2: note: here
> case XenbusStateUnknown:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied to for-linus-5.0
(xen-scsiback patch too)
-boris
next prev parent reply other threads:[~2019-02-12 23:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 20:37 [PATCH] xen: mark expected switch fall-through Gustavo A. R. Silva
2019-02-12 23:50 ` Boris Ostrovsky [this message]
2019-02-13 0:54 ` Gustavo A. R. Silva
2019-02-13 5:50 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212235041.GA4463@localhost.localdomain \
--to=boris.ostrovsky@oracle.com \
--cc=gustavo@embeddedor.com \
--cc=jgross@suse.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox