From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63FEFC282CA for ; Wed, 13 Feb 2019 03:05:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32FEF207E0 for ; Wed, 13 Feb 2019 03:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550027146; bh=ZLFUht7hIIVL9uobfeygydIdOhVKV6qpwROEUVYW4CU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Ws9owGfHPDPAVS+tY9NluK0ExPWfSqThaL6Lun4ZDl7+RvLypHy/D9sxi0U40hl4e H7lE2cVZVT0EbWQOIXgPs8Yj5BYv+y1n0dhXLU+J/tNWpPoy7yu43LMgOiwdeJnqHh c5yHDE4POtb5Q1Ev8SFue3GUtaJaUMV9gk1tkLlo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390493AbfBMDFo (ORCPT ); Tue, 12 Feb 2019 22:05:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:37562 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387507AbfBMCdz (ORCPT ); Tue, 12 Feb 2019 21:33:55 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A493E222C9; Wed, 13 Feb 2019 02:33:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550025235; bh=ZLFUht7hIIVL9uobfeygydIdOhVKV6qpwROEUVYW4CU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ArYVn0QzsFcqA7QSn5tRjhQtDoDvLWPkjanDuhGQzvn7nwdDu0WQTobYh2TKpy5Ea zFO0P6lZBuN/qOKciNGLxnpJuIxZMS3DUo0FztDMxKd+sCi7PEqT6P3SlevK13GCU1 4IOqhf7C6zDTjfsYJfNcmgtek/DPrH2AElt9aoUg= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Enric Balletbo i Serra , Lee Jones , Sasha Levin Subject: [PATCH AUTOSEL 4.20 018/105] mfd: cros_ec_dev: Add missing mfd_remove_devices() call in remove Date: Tue, 12 Feb 2019 21:32:09 -0500 Message-Id: <20190213023336.19019-18-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190213023336.19019-1-sashal@kernel.org> References: <20190213023336.19019-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Enric Balletbo i Serra [ Upstream commit 18e294ddafaeb80a1e2e10c9bd750a6cb8388d5b ] The driver adds different MFD child devices via mfd_add_devices() and hence it is required to call mfd_remove_devices() to remove MFD child devices. Fixes: 5e0115581bbc ("cros_ec: Move cros_ec_dev module to drivers/mfd") Signed-off-by: Enric Balletbo i Serra Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/cros_ec_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index b99a194ce5a4..2d0fee488c5a 100644 --- a/drivers/mfd/cros_ec_dev.c +++ b/drivers/mfd/cros_ec_dev.c @@ -499,6 +499,7 @@ static int ec_device_remove(struct platform_device *pdev) cros_ec_debugfs_remove(ec); + mfd_remove_devices(ec->dev); cdev_del(&ec->cdev); device_unregister(&ec->class_dev); return 0; -- 2.19.1