From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B36C282C4 for ; Wed, 13 Feb 2019 02:50:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B11621934 for ; Wed, 13 Feb 2019 02:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550026202; bh=QBIuctLtVlS9aMbkxcGI8DEbrjCG/na/F621DTyBIPI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=z0hD4JQ7xAd0++P+VwdO7AxaBFkWj46t0WkWYdUewVK9Z3UlMB9esRoGwat0cwU1m gUlPCIvnUl0+k29bwsXpsZzBIOdtU8vqGd85/LoJpd1Y1gBzpKLUvHWuNfkwqdW1hE jAqvUv+pQeDY1gS5bQm6vrGbNUZ9PN0k39DtQHro= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389721AbfBMCuA (ORCPT ); Tue, 12 Feb 2019 21:50:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:43640 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388862AbfBMCkA (ORCPT ); Tue, 12 Feb 2019 21:40:00 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 671B02175B; Wed, 13 Feb 2019 02:39:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550025600; bh=QBIuctLtVlS9aMbkxcGI8DEbrjCG/na/F621DTyBIPI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O70yjzWILmR5WNgW3QmBFaSIbHkIFkqzvfZzd4cvMNho3kYZ7F1nQ50Yl3ZEVi+/3 bJAvuGSxSGWrZykXYAVqwBroWpjidj5bZpeezfbu2Yw5t87PJSSImrIwUI1ri4UQE3 Mc0XIiW75sJr8YhY9DG1kxhjFJzyHjoVopQoXXhs= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Lee Jones , Sasha Levin Subject: [PATCH AUTOSEL 4.14 06/34] mfd: ab8500-core: Return zero in get_register_interruptible() Date: Tue, 12 Feb 2019 21:39:24 -0500 Message-Id: <20190213023952.21311-6-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190213023952.21311-1-sashal@kernel.org> References: <20190213023952.21311-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 10628e3ecf544fa2e4e24f8e112d95c37884dc98 ] This function is supposed to return zero on success or negative error codes on error. Unfortunately, there is a bug so it sometimes returns non-zero, positive numbers on success. I noticed this bug during review and I can't test it. It does appear that the return is sometimes propogated back to _regmap_read() where all non-zero returns are treated as failure so this may affect run time. Fixes: 47c1697508f2 ("mfd: Align ab8500 with the abx500 interface") Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/ab8500-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c index 30d09d177171..11ab17f64c64 100644 --- a/drivers/mfd/ab8500-core.c +++ b/drivers/mfd/ab8500-core.c @@ -261,7 +261,7 @@ static int get_register_interruptible(struct ab8500 *ab8500, u8 bank, mutex_unlock(&ab8500->lock); dev_vdbg(ab8500->dev, "rd: addr %#x => data %#x\n", addr, ret); - return ret; + return (ret < 0) ? ret : 0; } static int ab8500_get_register(struct device *dev, u8 bank, -- 2.19.1