From: Peter Zijlstra <peterz@infradead.org>
To: Kees Cook <keescook@chromium.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Dmitry Vyukov <dvyukov@google.com>,
syzbot <syzbot+352bd10e338d9a90e5e0@syzkaller.appspotmail.com>,
Abderrahmane Benbachir <abderrahmane.benbachir@polymtl.ca>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Subject: Re: WARNING in event_function_local
Date: Wed, 13 Feb 2019 10:51:58 +0100 [thread overview]
Message-ID: <20190213095158.GM32494@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAGXu5j+Z=ns37DdNU-mYtfio1cW4c25jyAGwFx74YFXKM5SD1A@mail.gmail.com>
On Tue, Feb 12, 2019 at 07:40:12PM -0800, Kees Cook wrote:
> > > Is this maybe just an unlucky condition with the event loop running in
> > > an IRQ? Should the WARN be expected, or is running under an IRQ
> > > unexpected?
>
> Is perf expected to fire during an IRQ? The task == current test seems
> suspicious if so...
So the only possible callchain here is:
<PMI>
...
perf_event_disable_inatomic()
irq_work_queue()
<irq_work-IPI>
perf_pending_event()
perf_event_disable_local()
event_function_local()
The assertion states that:
if the event is a task event; and the context is active, it _must_ be
the same task.
Because: if the PMI happens during ctxsw (which has IRQs disabled), the
IPI will not happen until after the ctxsw, at which point we'll also
have switched out the perf context of that task -- IOW the context
should be inactive.
Anyway, it looks like a virt issue; I'll start caring once you can
reproduce on real hardware.
next prev parent reply other threads:[~2019-02-13 9:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 19:58 WARNING in event_function_local syzbot
2018-05-10 5:18 ` Dmitry Vyukov
2019-02-13 1:27 ` Kees Cook
2019-02-13 2:14 ` Steven Rostedt
2019-02-13 3:40 ` Kees Cook
2019-02-13 3:46 ` Steven Rostedt
2019-02-13 9:51 ` Peter Zijlstra [this message]
2019-02-13 9:57 ` Peter Zijlstra
2019-02-13 10:16 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213095158.GM32494@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=abderrahmane.benbachir@polymtl.ca \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=dvyukov@google.com \
--cc=jolsa@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=syzbot+352bd10e338d9a90e5e0@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox