From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51C91C282C2 for ; Wed, 13 Feb 2019 11:02:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D4EC222B1 for ; Wed, 13 Feb 2019 11:02:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403862AbfBMLCo (ORCPT ); Wed, 13 Feb 2019 06:02:44 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:49438 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391692AbfBMLCm (ORCPT ); Wed, 13 Feb 2019 06:02:42 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 666FC802FA; Wed, 13 Feb 2019 12:02:32 +0100 (CET) Date: Wed, 13 Feb 2019 12:02:38 +0100 From: Pavel Machek To: Bartosz Golaszewski Cc: Lee Jones , Bartosz Golaszewski , Rob Herring , Mark Rutland , Linus Walleij , Dmitry Torokhov , Jacek Anaszewski , Sebastian Reichel , Liam Girdwood , Greg Kroah-Hartman , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , devicetree , Linux Input , Linux LED Subsystem , Linux PM list , Mark Brown Subject: Re: [PATCH v4 05/10] mfd: max77650: new core mfd driver Message-ID: <20190213110238.GA30507@amd> References: <20190212095457.GA20638@dell> <20190212101835.GB20638@dell> <20190212111403.GC20638@dell> <20190212132016.GA4781@dell> <20190213092553.GE1863@dell> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WIyZ46R2i8wDzkSu" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --WIyZ46R2i8wDzkSu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > As you can see, it will return the IRQ Domain for the chip. > > > > You can then pass this IRQ domain to mfd_add_devices() and it will do > > the HWIRQ =3D> VIRQ mapping for you on the fly. Meaning that you can > > remove all the nastiness in max77650_setup_irqs() and have the Input > > device use the standard (e.g. platform_get_irq()) APIs. > > > > How does that Sound? >=20 > This does sound better! Why didn't you lead with that in the first >place? TBH, this can be considered rude and I'm not surprised Lee reacted the way he did. > It's a pity it's not documented, I had to look at the code to find out > irq resources would get translated in mfd_add_devices() if a domain is > present. I guess documentation patch would be welcome. Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --WIyZ46R2i8wDzkSu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlxj+U4ACgkQMOfwapXb+vL/BQCdEGkaJPfLbI+tEuJVF0ANhxsc 5acAn2oCVZb7slwa63nJgPYYkBk4vrzA =8OAJ -----END PGP SIGNATURE----- --WIyZ46R2i8wDzkSu--