From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A06DEC282C2 for ; Wed, 13 Feb 2019 11:50:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 661E2222BE for ; Wed, 13 Feb 2019 11:50:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550058618; bh=Twl0oY8CPuSXvcynVRJOF03+Imr0e5cU4OvTjwPPrA0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=pgInkBk3ujh9K11r+/Je3w9QZoL176R0t8cuzw0qkdAlt+MFhFFngFuf2QnKIl+VR HrLR2er+nKtfOhhGrkyZJv02fSsdKdO6H3yZjfpnXYawZ3mH36Mueq7ecw+bCUd8UB Vs+LrpPax1PiSTFWGgif07zVNw2Pusvyc0QTNyl4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733176AbfBMLuR (ORCPT ); Wed, 13 Feb 2019 06:50:17 -0500 Received: from mx2.suse.de ([195.135.220.15]:49404 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726411AbfBMLuQ (ORCPT ); Wed, 13 Feb 2019 06:50:16 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6C746ABAC; Wed, 13 Feb 2019 11:50:15 +0000 (UTC) Date: Wed, 13 Feb 2019 12:50:14 +0100 From: Michal Hocko To: Peter Zijlstra Cc: linux-mm@kvack.org, Pingfan Liu , Dave Hansen , x86@kernel.org, Benjamin Herrenschmidt , Michael Ellerman , Tony Luck , linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org, LKML , Ingo Molnar Subject: Re: [PATCH v3 2/2] mm: be more verbose about zonelist initialization Message-ID: <20190213115014.GC4525@dhcp22.suse.cz> References: <20190212095343.23315-3-mhocko@kernel.org> <20190213094315.3504-1-mhocko@kernel.org> <20190213103231.GN32494@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190213103231.GN32494@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 13-02-19 11:32:31, Peter Zijlstra wrote: > On Wed, Feb 13, 2019 at 10:43:15AM +0100, Michal Hocko wrote: > > @@ -5259,6 +5261,11 @@ static void build_zonelists(pg_data_t *pgdat) > > > > build_zonelists_in_node_order(pgdat, node_order, nr_nodes); > > build_thisnode_zonelists(pgdat); > > + > > + pr_info("node[%d] zonelist: ", pgdat->node_id); > > + for_each_zone_zonelist(zone, z, &pgdat->node_zonelists[ZONELIST_FALLBACK], MAX_NR_ZONES-1) > > + pr_cont("%d:%s ", zone_to_nid(zone), zone->name); > > + pr_cont("\n"); > > } > > Have you ran this by the SGI and other stupid large machine vendors? I do not have such a large machine handy. The biggest I have has handfull (say dozen) of NUMA nodes. > Traditionally they tend to want to remove such things instead of adding > them. I do not insist on this patch but I find it handy. If there is an opposition I will not miss it much. -- Michal Hocko SUSE Labs