From: Tony Lindgren <tony@atomide.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Florian Vaussard <florian.vaussard@epfl.ch>,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: [PATCH] mfd: twl6040: Fix device init errors for ACCCTL register
Date: Thu, 14 Feb 2019 08:03:02 -0800 [thread overview]
Message-ID: <20190214160302.GE5720@atomide.com> (raw)
In-Reply-To: <20190214092045.GD13737@dell>
* Lee Jones <lee.jones@linaro.org> [190214 09:21]:
> On Mon, 11 Feb 2019, Tony Lindgren wrote:
> > + ret = regcache_sync(twl6040->regmap);
> > + if (ret) {
> > + dev_err(twl6040->dev, "%s register write failed: %i\n",
> > + __func__, ret);
>
> Please drop the __func__ and just use the standard format.
>
> Wouldn't something a little more forthcoming be better?
>
> "Failed to sync with the HW" ?
Sure I'll send an updated patch.
Regards,
Tony
prev parent reply other threads:[~2019-02-14 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 22:57 [PATCH] mfd: twl6040: Fix device init errors for ACCCTL register Tony Lindgren
2019-02-12 7:50 ` Peter Ujfalusi
2019-02-14 9:20 ` Lee Jones
2019-02-14 16:03 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214160302.GE5720@atomide.com \
--to=tony@atomide.com \
--cc=florian.vaussard@epfl.ch \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).