From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77A17C4360F for ; Thu, 14 Feb 2019 17:46:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 553AE222DA for ; Thu, 14 Feb 2019 17:46:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405539AbfBNRqU (ORCPT ); Thu, 14 Feb 2019 12:46:20 -0500 Received: from muru.com ([72.249.23.125]:38890 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393650AbfBNRqR (ORCPT ); Thu, 14 Feb 2019 12:46:17 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 4E2E680EA; Thu, 14 Feb 2019 17:46:25 +0000 (UTC) Date: Thu, 14 Feb 2019 09:46:12 -0800 From: Tony Lindgren To: Lokesh Vutla Cc: marc.zyngier@arm.com, Nishanth Menon , Santosh Shilimkar , Rob Herring , tglx@linutronix.de, jason@lakedaemon.net, Linux ARM Mailing List , linux-kernel@vger.kernel.org, Device Tree Mailing List , Sekhar Nori , Tero Kristo , Peter Ujfalusi Subject: Re: [PATCH v5 05/10] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings Message-ID: <20190214174612.GF5720@atomide.com> References: <20190212074237.2875-1-lokeshvutla@ti.com> <20190212074237.2875-6-lokeshvutla@ti.com> <20190212162247.GK5720@atomide.com> <6a274588-0fb6-2ddf-3bcc-f9e4d849ac07@ti.com> <20190213152620.GS5720@atomide.com> <4791de04-63af-4c5e-db9c-47634fcb8dc9@ti.com> <20190214154100.GB5720@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Lokesh Vutla [190214 17:32]: > Hi Tony, > Please do not snip the on going discussion. > > On 2/14/2019 9:11 PM, Tony Lindgren wrote: > > * Lokesh Vutla [190214 08:39]: > >> IMHO, device ids are something which can be used in DT. There are many other > >> things like the interrupt ranges etc.. which are discoverable from sysfw and we > >> are implementing it. > > > > We need to describe hardware in the device tree, not firmware. > > > > If you have something discoverable from the firmware, you should > > have the device driver query it from sysfw based on a hardware > > property, not based on some invented enumeration in the firmware. > > Yes we are already querying sysfw for all the irq ranges that can be > discoverable. The topic of discussion here is about the parent interrupt > controller id. I am not sure how you are expecting an id be discoverable > from system firmware especially with a name. Well names are quite standard in dts (but should be used with the phandle + offset). Think for example interrupt-names and reg-names :) > > If there is some device to firmware translation needed, hide that > > into the device driver and keep it out of the device tree. > > If preferred this can be moved to of_match_data attached to each > compatible property. Then for each SoC a new compatible needs to be created. Hiding the ID into the device driver and compatible property makes sense to me if the id is based on SoC + firmware. But I'd rather have a proper hardware based phandle + index type mapping in the dts if possible though. What does this id really consist of? Regards, Tony