From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93FA3C10F04 for ; Thu, 14 Feb 2019 22:24:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69D2F2177E for ; Thu, 14 Feb 2019 22:24:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406437AbfBNWYk (ORCPT ); Thu, 14 Feb 2019 17:24:40 -0500 Received: from mslow2.mail.gandi.net ([217.70.178.242]:55550 "EHLO mslow2.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2440524AbfBNWYZ (ORCPT ); Thu, 14 Feb 2019 17:24:25 -0500 Received: from relay12.mail.gandi.net (unknown [217.70.178.232]) by mslow2.mail.gandi.net (Postfix) with ESMTP id D0D063A4B86; Thu, 14 Feb 2019 23:17:06 +0100 (CET) Received: from localhost (lfbn-lyo-1-149-219.w86-202.abo.wanadoo.fr [86.202.231.219]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id C7A34200009; Thu, 14 Feb 2019 22:17:03 +0000 (UTC) Date: Thu, 14 Feb 2019 23:17:03 +0100 From: Alexandre Belloni To: "Gustavo A. R. Silva" Cc: Nicolas.Ferre@microchip.com, wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net, Ludovic.Desroches@microchip.com, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] can: mark expected switch fall-throughs Message-ID: <20190214221703.GQ10129@piout.net> References: <20190129180612.GA28650@embeddedor> <432a9399-95f4-e988-5cd2-93340f155fa1@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 14/02/2019 15:37:26-0600, Gustavo A. R. Silva wrote: > > > On 1/30/19 2:11 AM, Nicolas.Ferre@microchip.com wrote: > > On 29/01/2019 at 19:06, Gustavo A. R. Silva wrote: > >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases > >> where we are expecting to fall through. > >> > >> This patch fixes the following warnings: > >> > >> drivers/net/can/peak_canfd/peak_pciefd_main.c:668:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > >> drivers/net/can/spi/mcp251x.c:875:7: warning: this statement may fall through [-Wimplicit-fallthrough=] > >> drivers/net/can/usb/peak_usb/pcan_usb.c:422:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > >> drivers/net/can/at91_can.c:895:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > >> drivers/net/can/at91_can.c:953:15: warning: this statement may fall through [-Wimplicit-fallthrough=] > >> drivers/net/can/usb/peak_usb/pcan_usb.c: In function ‘pcan_usb_decode_error’: > >> drivers/net/can/usb/peak_usb/pcan_usb.c:422:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > >> if (n & PCAN_USB_ERROR_BUS_LIGHT) { > >> ^ > >> drivers/net/can/usb/peak_usb/pcan_usb.c:428:2: note: here > >> case CAN_STATE_ERROR_WARNING: > >> ^~~~ > >> > >> Warning level 3 was used: -Wimplicit-fallthrough=3 > >> > >> This patch is part of the ongoing efforts to enabling > >> -Wimplicit-fallthrough. > >> > >> Notice that in some cases spelling mistakes were fixed. > >> In other cases, the /* fall through */ comment is placed > >> at the bottom of the case statement, which is what GCC > >> is expecting to find. > >> > >> Signed-off-by: Gustavo A. R. Silva > >> --- > >> drivers/net/can/at91_can.c | 6 ++++-- > > > > For this one: > > Acked-by: Nicolas Ferre > > > > Thanks, Nicolas. > I though I had a déjà vu but you actually sent the at91 part twice. > Dave: > > I wonder if you can take this patch. > > Thanks > -- > Gustavo > > >> drivers/net/can/peak_canfd/peak_pciefd_main.c | 2 +- > >> drivers/net/can/spi/mcp251x.c | 3 ++- > >> drivers/net/can/usb/peak_usb/pcan_usb.c | 2 +- > >> 4 files changed, 8 insertions(+), 5 deletions(-) > >> > >> diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c > >> index d98c69045b17..1718c20f9c99 100644 > >> --- a/drivers/net/can/at91_can.c > >> +++ b/drivers/net/can/at91_can.c > >> @@ -902,7 +902,8 @@ static void at91_irq_err_state(struct net_device *dev, > >> CAN_ERR_CRTL_TX_WARNING : > >> CAN_ERR_CRTL_RX_WARNING; > >> } > >> - case CAN_STATE_ERROR_WARNING: /* fallthrough */ > >> + /* fall through */ > >> + case CAN_STATE_ERROR_WARNING: > >> /* > >> * from: ERROR_ACTIVE, ERROR_WARNING > >> * to : ERROR_PASSIVE, BUS_OFF > >> @@ -951,7 +952,8 @@ static void at91_irq_err_state(struct net_device *dev, > >> netdev_dbg(dev, "Error Active\n"); > >> cf->can_id |= CAN_ERR_PROT; > >> cf->data[2] = CAN_ERR_PROT_ACTIVE; > >> - case CAN_STATE_ERROR_WARNING: /* fallthrough */ Seriously, for that one, you should fix the compiler. The fall through is not implicit, it is actually quite explicit and the warning is simply wrong. Also, the gcc documentation says that -Wimplicit-fallthrough=3 recognizes /* fallthrough */ as a proper fall through comment (and I tested with gcc 8.2). The matching regex is [ \t.!]*([Ee]lse,? |[Ii]ntentional(ly)? )? fall(s | |-)?thr(ough|u)[ \t.!]*(-[^\n\r]*)? -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com