From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Varun Prakash <varun@chelsio.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Sasha Levin <sashal@kernel.org>,
linux-scsi@vger.kernel.org
Subject: [PATCH AUTOSEL 4.19 45/65] scsi: csiostor: fix NULL pointer dereference in csio_vport_set_state()
Date: Thu, 14 Feb 2019 21:11:01 -0500 [thread overview]
Message-ID: <20190215021121.177674-45-sashal@kernel.org> (raw)
In-Reply-To: <20190215021121.177674-1-sashal@kernel.org>
From: Varun Prakash <varun@chelsio.com>
[ Upstream commit fe35a40e675473eb65f2f5462b82770f324b5689 ]
Assign fc_vport to ln->fc_vport before calling csio_fcoe_alloc_vnp() to
avoid a NULL pointer dereference in csio_vport_set_state().
ln->fc_vport is dereferenced in csio_vport_set_state().
Signed-off-by: Varun Prakash <varun@chelsio.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/scsi/csiostor/csio_attr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/csiostor/csio_attr.c b/drivers/scsi/csiostor/csio_attr.c
index 8a004036e3d7..9bd2bd8dc2be 100644
--- a/drivers/scsi/csiostor/csio_attr.c
+++ b/drivers/scsi/csiostor/csio_attr.c
@@ -594,12 +594,12 @@ csio_vport_create(struct fc_vport *fc_vport, bool disable)
}
fc_vport_set_state(fc_vport, FC_VPORT_INITIALIZING);
+ ln->fc_vport = fc_vport;
if (csio_fcoe_alloc_vnp(hw, ln))
goto error;
*(struct csio_lnode **)fc_vport->dd_data = ln;
- ln->fc_vport = fc_vport;
if (!fc_vport->node_name)
fc_vport->node_name = wwn_to_u64(csio_ln_wwnn(ln));
if (!fc_vport->port_name)
--
2.19.1
next prev parent reply other threads:[~2019-02-15 2:31 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 2:10 [PATCH AUTOSEL 4.19 01/65] drm/msm: Unblock writer if reader closes file Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 02/65] ASoC: Intel: Haswell/Broadwell: fix setting for .dynamic field Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 03/65] ALSA: compress: prevent potential divide by zero bugs Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 04/65] ASoC: Variable "val" in function rt274_i2c_probe() could be uninitialized Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 05/65] clk: tegra: dfll: Fix a potential Oop in remove() Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 06/65] clk: sysfs: fix invalid JSON in clk_dump Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 07/65] clk: vc5: Abort clock configuration without upstream clock Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 08/65] thermal: int340x_thermal: Fix a NULL vs IS_ERR() check Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 09/65] usb: dwc3: gadget: synchronize_irq dwc irq in suspend Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 10/65] usb: dwc3: gadget: Fix the uninitialized link_state when udc starts Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 11/65] usb: gadget: Potential NULL dereference on allocation error Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 12/65] selftests: rtc: rtctest: fix alarm tests Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 13/65] selftests: rtc: rtctest: add alarm test on minute boundary Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 14/65] genirq: Make sure the initial affinity is not empty Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 15/65] x86/mm/mem_encrypt: Fix erroneous sizeof() Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 16/65] ASoC: rt5682: Fix PLL source register definitions Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 17/65] ASoC: dapm: change snprintf to scnprintf for possible overflow Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 18/65] ASoC: imx-audmux: " Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 19/65] selftests/vm/gup_benchmark.c: match gup struct to kernel Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 20/65] phy: ath79-usb: Fix the power on error path Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 21/65] phy: ath79-usb: Fix the main reset name to match the DT binding Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 22/65] selftests: seccomp: use LDLIBS instead of LDFLAGS Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 23/65] selftests: gpio-mockup-chardev: Check asprintf() for error Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 24/65] irqchip/gic-v3-mbi: Fix uninitialized mbi_lock Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 25/65] ARC: fix __ffs return value to avoid build warnings Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 26/65] ARC: show_regs: lockdep: avoid page allocator Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 27/65] drivers: thermal: int340x_thermal: Fix sysfs race condition Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 28/65] staging: rtl8723bs: Fix build error with Clang when inlining is disabled Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 29/65] mac80211: fix miscounting of ttl-dropped frames Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 30/65] sched/wait: Fix rcuwait_wake_up() ordering Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 31/65] sched/wake_q: Fix wakeup ordering for wake_q Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 32/65] futex: Fix (possible) missed wakeup Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 33/65] locking/rwsem: " Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 34/65] libceph: avoid KEEPALIVE_PENDING races in ceph_con_keepalive() Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 35/65] drm/amd/powerplay: OD setting fix on Vega10 Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 36/65] tty: serial: qcom_geni_serial: Allow mctrl when flow control is disabled Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 37/65] serial: fsl_lpuart: fix maximum acceptable baud rate with over-sampling Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 38/65] drm/sun4i: hdmi: Fix usage of TMDS clock Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 39/65] staging: android: ion: Support cpu access during dma_buf_detach Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 40/65] direct-io: allow direct writes to empty inodes Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 41/65] block: cover another queue enter recursion via BIO_QUEUE_ENTERED Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 42/65] writeback: synchronize sync(2) against cgroup writeback membership switches Sasha Levin
2019-02-15 2:10 ` [PATCH AUTOSEL 4.19 43/65] scsi: lpfc: nvme: avoid hang / use-after-free when destroying localport Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 44/65] scsi: lpfc: nvmet: avoid hang / use-after-free when destroying targetport Sasha Levin
2019-02-15 2:11 ` Sasha Levin [this message]
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 46/65] net: altera_tse: fix connect_local_phy error path Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 47/65] hv_netvsc: Fix ethtool change hash key error Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 48/65] hv_netvsc: Refactor assignments of struct netvsc_device_info Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 49/65] hv_netvsc: Fix hash key value reset after other ops Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 50/65] sfc: suppress duplicate nvmem partition types in efx_ef10_mtd_probe Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 51/65] ax25: fix possible use-after-free Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 52/65] nvme-rdma: fix timeout handler Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 53/65] nvme-multipath: drop optimization for static ANA group IDs Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 54/65] drm/msm: Fix A6XX support for opp-level Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 55/65] CIFS: Do not assume one credit for async responses Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 56/65] net: usb: asix: ax88772_bind return error when hw_reset fail Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 57/65] net: dev_is_mac_header_xmit() true for ARPHRD_RAWIP Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 58/65] ibmveth: Do not process frames after calling napi_reschedule Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 59/65] mac80211: don't initiate TDLS connection if station is not associated to AP Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 60/65] mac80211: Add attribute aligned(2) to struct 'action' Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 61/65] cfg80211: extend range deviation for DMG Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 62/65] svm: Fix AVIC incomplete IPI emulation Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 63/65] KVM: nSVM: clear events pending from svm_complete_interrupts() when exiting to L1 Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 64/65] kvm: selftests: Fix region overlap check in kvm_util Sasha Levin
2019-02-15 2:11 ` [PATCH AUTOSEL 4.19 65/65] Revert "block: cover another queue enter recursion via BIO_QUEUE_ENTERED" Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215021121.177674-45-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox