From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35A4CC43381 for ; Fri, 15 Feb 2019 02:30:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F030420840 for ; Fri, 15 Feb 2019 02:30:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550197803; bh=5+7x3q8RdW0GEJgGwSGI9Vyvh3PwH0HjYorp57NGYBk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=azuGbeawjrop0T5pKR+5Iv/6YNofEZcF/OYqLK6m8d0JXuc26W/Taxh1eDTCrjNz1 4C8uvoJ3QEwd/K/RZlqSWr4wsu23SwGuxNKsoJovKQ4yM5EprLB5oXN/rlTavVf3XV KYRS/zo0wfSwibLXmkNpX+DsETk5RCVduaYx1r7E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730820AbfBOCaB (ORCPT ); Thu, 14 Feb 2019 21:30:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:52974 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391286AbfBOCNA (ORCPT ); Thu, 14 Feb 2019 21:13:00 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 232D521B1C; Fri, 15 Feb 2019 02:12:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550196779; bh=5+7x3q8RdW0GEJgGwSGI9Vyvh3PwH0HjYorp57NGYBk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TXe5/Ua7X2LIHkmTdwKn6gkutmeZzXo8bv5IlzjNPnefnN6/cmjUR6rR65AnnYTKU S+/9O1XsYMG7Ebf1rEHx+LjSx3/msSPdhA4/YPeVfuQ08wdjAFJrVJofX1SHpdeAxc yd0ylTqB4oKWIXNHSHs4jSegXeCc/GqKXBStNE/A= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Thomas Falcon , "David S . Miller" , Sasha Levin , linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 58/65] ibmveth: Do not process frames after calling napi_reschedule Date: Thu, 14 Feb 2019 21:11:14 -0500 Message-Id: <20190215021121.177674-58-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190215021121.177674-1-sashal@kernel.org> References: <20190215021121.177674-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Falcon [ Upstream commit e95d22c69b2c130ccce257b84daf283fd82d611e ] The IBM virtual ethernet driver's polling function continues to process frames after rescheduling NAPI, resulting in a warning if it exhausted its budget. Do not restart polling after calling napi_reschedule. Instead let frames be processed in the following instance. Signed-off-by: Thomas Falcon Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/ibm/ibmveth.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index 91f48c078073..f70cb4d3c684 100644 --- a/drivers/net/ethernet/ibm/ibmveth.c +++ b/drivers/net/ethernet/ibm/ibmveth.c @@ -1314,7 +1314,6 @@ static int ibmveth_poll(struct napi_struct *napi, int budget) unsigned long lpar_rc; u16 mss = 0; -restart_poll: while (frames_processed < budget) { if (!ibmveth_rxq_pending_buffer(adapter)) break; @@ -1402,7 +1401,6 @@ static int ibmveth_poll(struct napi_struct *napi, int budget) napi_reschedule(napi)) { lpar_rc = h_vio_signal(adapter->vdev->unit_address, VIO_IRQ_DISABLE); - goto restart_poll; } } -- 2.19.1