From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B94FC43381 for ; Fri, 15 Feb 2019 02:13:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7FD3206BA for ; Fri, 15 Feb 2019 02:13:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550196808; bh=/hw5VzZ9kV5WigoCJYi9Yy6gInI88/adGsX98x7zCeU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=VNZye8TW7Pi+41otA+dFogQir8T+ISH2S4NIaHREO1QkgnYuycbsNvW+wILJbXygY fS0j3sGxPWCc58pB6D8BQcGo/PXzARc0xYiCzxVl1m75x4M5mCE/6Sph4rUCqVrefK DR4t2ZDCwENR0HgZWDLdQ34wtnFv1WWJk7Xlf5qs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391402AbfBOCNZ (ORCPT ); Thu, 14 Feb 2019 21:13:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:53292 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404668AbfBOCNW (ORCPT ); Thu, 14 Feb 2019 21:13:22 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C72952229F; Fri, 15 Feb 2019 02:13:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550196801; bh=/hw5VzZ9kV5WigoCJYi9Yy6gInI88/adGsX98x7zCeU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TKXrRqeuRalgEGA1C2fMAzktlEnkrbk/WJYYw7nxNG/zaPjDSaDdlJMQvHXCBDAOR z67AC0Kv+ZEPl6b9QYvczMtypaAKXdbMRkTg/dMUNbApDYlpd8lZ8QWmXpvZH1/wJa v5L6hWXmH1yYY2bVEQGcbmp0DTctlRlD98mOV8dM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yizhuo , Mark Brown , Sasha Levin Subject: [PATCH AUTOSEL 4.14 04/40] ASoC: Variable "val" in function rt274_i2c_probe() could be uninitialized Date: Thu, 14 Feb 2019 21:12:37 -0500 Message-Id: <20190215021313.178476-4-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190215021313.178476-1-sashal@kernel.org> References: <20190215021313.178476-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yizhuo [ Upstream commit 8c3590de0a378c2449fc1aec127cc693632458e4 ] Inside function rt274_i2c_probe(), if regmap_read() function returns -EINVAL, then local variable "val" leaves uninitialized but used in if statement. This is potentially unsafe. Signed-off-by: Yizhuo Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/rt274.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt274.c b/sound/soc/codecs/rt274.c index 8f92e5c4dd9d..cd048df76232 100644 --- a/sound/soc/codecs/rt274.c +++ b/sound/soc/codecs/rt274.c @@ -1128,8 +1128,11 @@ static int rt274_i2c_probe(struct i2c_client *i2c, return ret; } - regmap_read(rt274->regmap, + ret = regmap_read(rt274->regmap, RT274_GET_PARAM(AC_NODE_ROOT, AC_PAR_VENDOR_ID), &val); + if (ret) + return ret; + if (val != RT274_VENDOR_ID) { dev_err(&i2c->dev, "Device with ID register %#x is not rt274\n", val); -- 2.19.1