From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vineet Gupta <vgupta@synopsys.com>,
Sasha Levin <sashal@kernel.org>,
linux-snps-arc@lists.infradead.org
Subject: [PATCH AUTOSEL 4.9 10/27] ARC: fix __ffs return value to avoid build warnings
Date: Thu, 14 Feb 2019 21:14:07 -0500 [thread overview]
Message-ID: <20190215021424.178979-10-sashal@kernel.org> (raw)
In-Reply-To: <20190215021424.178979-1-sashal@kernel.org>
From: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
[ Upstream commit 4e868f8419cb4cb558c5d428e7ab5629cef864c7 ]
| CC mm/nobootmem.o
|In file included from ./include/asm-generic/bug.h:18:0,
| from ./arch/arc/include/asm/bug.h:32,
| from ./include/linux/bug.h:5,
| from ./include/linux/mmdebug.h:5,
| from ./include/linux/gfp.h:5,
| from ./include/linux/slab.h:15,
| from mm/nobootmem.c:14:
|mm/nobootmem.c: In function '__free_pages_memory':
|./include/linux/kernel.h:845:29: warning: comparison of distinct pointer types lacks a cast
| (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
| ^
|./include/linux/kernel.h:859:4: note: in expansion of macro '__typecheck'
| (__typecheck(x, y) && __no_side_effects(x, y))
| ^~~~~~~~~~~
|./include/linux/kernel.h:869:24: note: in expansion of macro '__safe_cmp'
| __builtin_choose_expr(__safe_cmp(x, y), \
| ^~~~~~~~~~
|./include/linux/kernel.h:878:19: note: in expansion of macro '__careful_cmp'
| #define min(x, y) __careful_cmp(x, y, <)
| ^~~~~~~~~~~~~
|mm/nobootmem.c:104:11: note: in expansion of macro 'min'
| order = min(MAX_ORDER - 1UL, __ffs(start));
Change __ffs return value from 'int' to 'unsigned long' as it
is done in other implementations (like asm-generic, x86, etc...)
to avoid build-time warnings in places where type is strictly
checked.
As __ffs may return values in [0-31] interval changing return
type to unsigned is valid.
Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/arc/include/asm/bitops.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arc/include/asm/bitops.h b/arch/arc/include/asm/bitops.h
index 8da87feec59a..99e6d8948f4a 100644
--- a/arch/arc/include/asm/bitops.h
+++ b/arch/arc/include/asm/bitops.h
@@ -340,7 +340,7 @@ static inline __attribute__ ((const)) int __fls(unsigned long x)
/*
* __ffs: Similar to ffs, but zero based (0-31)
*/
-static inline __attribute__ ((const)) int __ffs(unsigned long word)
+static inline __attribute__ ((const)) unsigned long __ffs(unsigned long word)
{
if (!word)
return word;
@@ -400,9 +400,9 @@ static inline __attribute__ ((const)) int ffs(unsigned long x)
/*
* __ffs: Similar to ffs, but zero based (0-31)
*/
-static inline __attribute__ ((const)) int __ffs(unsigned long x)
+static inline __attribute__ ((const)) unsigned long __ffs(unsigned long x)
{
- int n;
+ unsigned long n;
asm volatile(
" ffs.f %0, %1 \n" /* 0:31; 31(Z) if src 0 */
--
2.19.1
next prev parent reply other threads:[~2019-02-15 2:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 2:13 [PATCH AUTOSEL 4.9 01/27] drm/msm: Unblock writer if reader closes file Sasha Levin
2019-02-15 2:13 ` [PATCH AUTOSEL 4.9 02/27] ASoC: Intel: Haswell/Broadwell: fix setting for .dynamic field Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 03/27] ALSA: compress: prevent potential divide by zero bugs Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 04/27] thermal: int340x_thermal: Fix a NULL vs IS_ERR() check Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 05/27] usb: dwc3: gadget: synchronize_irq dwc irq in suspend Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 06/27] usb: dwc3: gadget: Fix the uninitialized link_state when udc starts Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 07/27] usb: gadget: Potential NULL dereference on allocation error Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 08/27] ASoC: dapm: change snprintf to scnprintf for possible overflow Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 09/27] ASoC: imx-audmux: " Sasha Levin
2019-02-15 2:14 ` Sasha Levin [this message]
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 11/27] drivers: thermal: int340x_thermal: Fix sysfs race condition Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 12/27] mac80211: fix miscounting of ttl-dropped frames Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 13/27] locking/rwsem: Fix (possible) missed wakeup Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 14/27] libceph: avoid KEEPALIVE_PENDING races in ceph_con_keepalive() Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 15/27] serial: fsl_lpuart: fix maximum acceptable baud rate with over-sampling Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 16/27] direct-io: allow direct writes to empty inodes Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 17/27] scsi: csiostor: fix NULL pointer dereference in csio_vport_set_state() Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 18/27] net: altera_tse: fix connect_local_phy error path Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 19/27] sfc: suppress duplicate nvmem partition types in efx_ef10_mtd_probe Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 20/27] ax25: fix possible use-after-free Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 21/27] net: usb: asix: ax88772_bind return error when hw_reset fail Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 22/27] ibmveth: Do not process frames after calling napi_reschedule Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 23/27] mac80211: don't initiate TDLS connection if station is not associated to AP Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 24/27] mac80211: Add attribute aligned(2) to struct 'action' Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 25/27] cfg80211: extend range deviation for DMG Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 26/27] svm: Fix AVIC incomplete IPI emulation Sasha Levin
2019-02-15 2:14 ` [PATCH AUTOSEL 4.9 27/27] KVM: nSVM: clear events pending from svm_complete_interrupts() when exiting to L1 Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215021424.178979-10-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox