From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 107F0C43381 for ; Fri, 15 Feb 2019 02:21:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BAD6220643 for ; Fri, 15 Feb 2019 02:21:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550197283; bh=YYZVPzGEdKsqa7iDI4HDJsast3VE1vT88vN+loSAVIY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ubqixI20hDLaYVmkZhTpPd6nFlkke8wxS14dywQ9eEYxWokF9aF7Qe6Lbs9uj+imW Md0IP/FPntdwBDrT1RU+/i23Gs69nySTFiEYIXQuK1+gcof5+7mOT3Wlr/d51MD0zN w8ZK8yPXhPJi933loyRtyMgmUiO7AllgjjWSEXOI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732965AbfBOCVW (ORCPT ); Thu, 14 Feb 2019 21:21:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:54914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405399AbfBOCPF (ORCPT ); Thu, 14 Feb 2019 21:15:05 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 294DA206BA; Fri, 15 Feb 2019 02:15:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550196905; bh=YYZVPzGEdKsqa7iDI4HDJsast3VE1vT88vN+loSAVIY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fusDmHmPvl6nZhNEltCTVLKaYS/H8EYohrkFx/2PhTm67kzbT4bsKrif52KqCLGPk 6Aqzd9rnYGTW1BAGTyHOKY5F9PEJJ0LQiiJU62qZrZVm+l3nU+VRMjxJSErS8mJbzX uTj9MS0jJBF3B2v6yN4dgaUCZ2/MUXGqGAcpehN0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Thomas Falcon , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH AUTOSEL 4.9 22/27] ibmveth: Do not process frames after calling napi_reschedule Date: Thu, 14 Feb 2019 21:14:19 -0500 Message-Id: <20190215021424.178979-22-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190215021424.178979-1-sashal@kernel.org> References: <20190215021424.178979-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Falcon [ Upstream commit e95d22c69b2c130ccce257b84daf283fd82d611e ] The IBM virtual ethernet driver's polling function continues to process frames after rescheduling NAPI, resulting in a warning if it exhausted its budget. Do not restart polling after calling napi_reschedule. Instead let frames be processed in the following instance. Signed-off-by: Thomas Falcon Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/ibm/ibmveth.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index 4996228fd7e6..955f658f3b65 100644 --- a/drivers/net/ethernet/ibm/ibmveth.c +++ b/drivers/net/ethernet/ibm/ibmveth.c @@ -1240,7 +1240,6 @@ static int ibmveth_poll(struct napi_struct *napi, int budget) struct iphdr *iph; u16 mss = 0; -restart_poll: while (frames_processed < budget) { if (!ibmveth_rxq_pending_buffer(adapter)) break; @@ -1338,7 +1337,6 @@ static int ibmveth_poll(struct napi_struct *napi, int budget) napi_reschedule(napi)) { lpar_rc = h_vio_signal(adapter->vdev->unit_address, VIO_IRQ_DISABLE); - goto restart_poll; } } -- 2.19.1