From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97674C43381 for ; Fri, 15 Feb 2019 02:16:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D7FD20643 for ; Fri, 15 Feb 2019 02:16:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550196976; bh=nKYasqKiRsdSyQooPd5Ac+SCy7UedpcIlQ3U9S7npvg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Jr+8GVtZnlCrEpCvhNpQReLu+B2RUtg7HSSuYYSQ1jyqdJIQv99zYy4Mcx4R8zXA+ gHM+EoabPIILkePTDz8//FAnlKUgMXLm/z2F5WyuPp+rTH01OOvEW8Fkt2GDbhfFAO tXlEFSQNdzDkHPq5KcAUfe6aOrZWfR8JvfMxr9OI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392327AbfBOCQO (ORCPT ); Thu, 14 Feb 2019 21:16:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:55600 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392168AbfBOCQH (ORCPT ); Thu, 14 Feb 2019 21:16:07 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B57A020643; Fri, 15 Feb 2019 02:16:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550196966; bh=nKYasqKiRsdSyQooPd5Ac+SCy7UedpcIlQ3U9S7npvg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fEpaLMitrhAfft4++h2wurD1jY5a8lcg60pEm+gMBr/X1BdpuR7jvuQkbRGV50bsz CKaaNC71QkFBXPNqR03xUANgmalinzF0sIYY3bxQ2hJA85qEdhtqcFnzgeLuTOI7sV vzvOnOgVKI35bje0SDfMqNcaH0tYsyio4pkA6uFI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Thomas Falcon , "David S . Miller" , Sasha Levin , linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 3.18 13/16] ibmveth: Do not process frames after calling napi_reschedule Date: Thu, 14 Feb 2019 21:15:43 -0500 Message-Id: <20190215021546.179605-13-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190215021546.179605-1-sashal@kernel.org> References: <20190215021546.179605-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Falcon [ Upstream commit e95d22c69b2c130ccce257b84daf283fd82d611e ] The IBM virtual ethernet driver's polling function continues to process frames after rescheduling NAPI, resulting in a warning if it exhausted its budget. Do not restart polling after calling napi_reschedule. Instead let frames be processed in the following instance. Signed-off-by: Thomas Falcon Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/ibm/ibmveth.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index 427a6674d237..f0301b1ff56c 100644 --- a/drivers/net/ethernet/ibm/ibmveth.c +++ b/drivers/net/ethernet/ibm/ibmveth.c @@ -1085,7 +1085,6 @@ static int ibmveth_poll(struct napi_struct *napi, int budget) int frames_processed = 0; unsigned long lpar_rc; -restart_poll: while (frames_processed < budget) { if (!ibmveth_rxq_pending_buffer(adapter)) break; @@ -1154,7 +1153,6 @@ static int ibmveth_poll(struct napi_struct *napi, int budget) napi_reschedule(napi)) { lpar_rc = h_vio_signal(adapter->vdev->unit_address, VIO_IRQ_DISABLE); - goto restart_poll; } } -- 2.19.1